forked from square/dagger
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin object module provisions for primitive types are missing object INSTANCE in generated code #1648
Comments
Thanks for the report. It looks like this is actually an issue with our handling of primitive types. |
Chang-Eric
changed the title
Qualified Kotlin object provisions are missing object INSTANCE in generated code
Kotlin object module provisions for primitive types are missing object INSTANCE in generated code
Oct 24, 2019
Btw, a workaround for this is to leave @JvmStatic on just the providers of primitive types. This will be fixed in the next release. |
Merged
kluever
pushed a commit
that referenced
this issue
Nov 7, 2019
…methods were not being dispatching through the singleton INSTANCE. Fixes #1648 RELNOTES=Fix #1648 where Kotlin object module providers of a primitive type would fail to compile ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=278454737
kluever
pushed a commit
that referenced
this issue
Nov 7, 2019
…methods were not being dispatching through the singleton INSTANCE. Fixes #1648 RELNOTES=Fix #1648 where Kotlin object module providers of a primitive type would fail to compile ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=278454737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I have a provision like below:
The resulting generated code should be accessing this provision via
MyModule.INSTANCE.provideMyBoolean()
, but.INSTANCE
is missing and thus fails to compile.Repro: ZacSweers/CatchUp#195. Run
./gradlew :app:compileDebugJavaWithJavac
The text was updated successfully, but these errors were encountered: