Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong arm neon detection #361

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix wrong arm neon detection #361

merged 1 commit into from
Aug 27, 2024

Conversation

gchatelet
Copy link
Collaborator

@gchatelet gchatelet commented Aug 27, 2024

ARM Architecture Reference Manual suggests to check for the presence of the Advanced SIMD instructions via __ARM_NEON

@gchatelet gchatelet requested a review from Mizux August 27, 2024 12:06
@gchatelet gchatelet changed the title Revert s/__ARM_NEON/__ARM_NEON__/g Fix wrong arm neon detection Aug 27, 2024
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

for the record:

<arm_neon.h> is provided to define the NEON intrinsics. As these intrinsics are in the user namespace, an
implementation would not normally define them until the header is included. The __ARM_NEON macro should be
tested before including the header:

 #ifdef __ARM_NEON
 #include <arm_neon.h>
 #endif /* __ARM_NEON */

ref: https://developer.arm.com/documentation/ihi0053/d/?lang=en (page 14)

@gchatelet gchatelet added the bug Something isn't working label Aug 27, 2024
@gchatelet gchatelet merged commit a4890d1 into main Aug 27, 2024
49 of 57 checks passed
@gchatelet gchatelet deleted the revert_neon_macro branch August 27, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants