Fix an array indexing bug when case-normalizing attributes

PiperOrigin-RevId: 690845649
google · Oct 29, 2024 · e8315b7 · e8315b7
1 parent f886504
commit e8315b7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/java/src/com/google/template/soy/data/SanitizedContent.java b/java/src/com/google/template/soy/data/SanitizedContent.java
@@ -675,7 +675,7 @@ private static String consumeAttributeName(String content, int position, int len
       // passes in the common case of no upper case characters.
       char[] chars = new char[position - start];
       content.getChars(start, position, chars, 0);
-      for (int i = upperCaseStartPos; i < position; i++) {
+      for (int i = 0; i < chars.length; i++) {
         chars[i] = Ascii.toLowerCase(chars[i]);
       }
       return String.valueOf(chars);

diff --git a/java/tests/com/google/template/soy/data/SanitizedContentsTest.java b/java/tests/com/google/template/soy/data/SanitizedContentsTest.java
@@ -420,6 +420,12 @@ public void testParseAttributes() {
     assertThat(parseAttributes("a='\"b'")).containsExactly("a", "&quot;b");
   }
 
+  @Test
+  public void testParseAttributes_withUppercase() {
+    assertThat(parseAttributes("CLASS=foo viewBox='1 2 3 4'"))
+        .isEqualTo(ImmutableMap.of("class", "foo", "viewbox", "1 2 3 4"));
+  }
+
   @Test
   public void testParseAttributes_errors() {
     assertThrows(IllegalArgumentException.class, () -> parseAttributes("a="));