-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for targeting multiple architectures #43
Comments
I snuck an additional note into my response: A long while ago, I evaluated the This is a great time to reevaluate. |
My first thought was to organize the generated rust rules into arch specific subdirectories under Something to the effect of:
As for the target triple mismatch, maybe its sufficient to statically map the most commonly used overlap between rustc and bazel. The default bazel toolchain (as of 0.8.1) looks like: |
Would it make more sense to do the select switching at the alias level or the generated BUILD file level? Also, rust_rules already has constraints based on target triples (https://github.com/bazelbuild/rules_rust/blob/master/rust/platform/platform.bzl). These can probably be used in the dependency selection. |
Hi, I'm interested in seeing this get done. Would it be possible to teach Particularly:
Here, 3 platforms would be targeted with the following dependencies
Then I think the @acmcarther @damienmg interested in your thoughts. |
I think that makes sense I am somehow worry about the explosion of configuration but if it only keeps platform that should be manageable. |
@damienmg can you elaborate a bit more on what you're concerned about with the explosion of configuration? |
If there is a lot of configuration this create a very complex graph that can be long to generate and to analyze by bazel. I doubt this will be the case here as there should not be 700 platforms to handles :) |
This feature is pretty important to us, as many crates depend on winapi when building on Windows (a target we support). |
Does #212 solve for this issue? |
@acmcarther Do you know if this can be closed? |
I think we can close this. If there are any additional features or issues that come up with the current implementation those can be brought up in separate issues. |
(Moving from: acmcarther/cargo-raze#33)
It would be great if there was a straightforward way to add support for multiple architectures at once. A bit like how the Bazel --ios_multi_cpus works, but perhaps just allow an array of targets in Cargo.toml, which generates arch specific rules.
Answer from @acmcarther:
"I'm certainly open to this, but each target generates features, build scripts, and dependencies that are different, and I haven't had a chance to give enough though to the best way to organize the generated files. Do you have any ideas in that respect?"
The text was updated successfully, but these errors were encountered: