Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent filter elements are not merged properly between feature modules and base modules #273

Closed
BenSchwab opened this issue Mar 15, 2022 · 1 comment

Comments

@BenSchwab
Copy link

Describe the bug
Intent filter elements are not merged from between a dynamic feature manifest and base feature manifest.
I believe this is because there is a typo in AndroidManifest.java: https://github.com/google/bundletool/blob/master/src/main/java/com/android/tools/build/bundletool/model/AndroidManifest.java#L76
public static final String INTENT_FILTER_ELEMENT_NAME = "intent-filder"; should be
public static final String INTENT_FILTER_ELEMENT_NAME = "intent-filter";

Bundletool version(s) affected
1.9.0

Stacktrace
N/A

To Reproduce
Create a dynamic feature with a manifest for an activity that contains an intent filter. In the base apk create a manifest entry for the same activity with the same intent filter.

Note that a universal apk only contains the intent-filter from the dynamic feature module.

Expected behavior
Universal apk should have the intent-filters from the base module and the dynamic feature module.

Known workaround
N/A

Environment:
OS: [e.g. iOS 10.3.3]

Additional context
Add any other context about the problem here.

@ymakhno
Copy link

ymakhno commented Apr 1, 2022

Fixed in 1.9.1.

@ymakhno ymakhno closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants