fix: icons not having their locations updated #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Apr 24, 2023
BeksOmega
added a commit
that referenced
this pull request
Apr 26, 2023
* fix: icons not having their locations updated * chore: fix running headful tests in node (cherry picked from commit 139bc29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6999
Proposed Changes
Adds a step to the queued render process that updates the location of icons.
Reason for Changes
Elements of a block don't get to decide where they are positioned, but some of them (icons and connections) need to know where they're positioned. Before the code for updating icons was hidden inside
moveConnectionswhich was triggered viarenderedConnection.tighten. Now it has been separated out so that it is clear what's happening.Test Coverage
Just manual testing =(
Documentation
N/A
Additional Information
N/A