Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): generator tests on linux #6588

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes an issue where the generator tests fail on Linux with

fenichel@fenichel-glaptop2:~/Documents/gblockly-rr$ npm run test:generators

> [email protected] test:generators
> gulp --silent testGenerators

=======================================
== generators
Cannot read properties of null (reading 'code')
FAILED: generators
fenichel@fenichel-glaptop2:~/Documents/gblockly-rr$

Proposed Changes

Remove trailing slashes from calls to rimraf.

Behavior Before Change

Crashes on linux

Behavior After Change

Tests run and don't crash.

Reason for Changes

Rimraf didn't like the trailing slash, which is surprising to me.

Additional Information

Caused by #6431 so we'll need to verify it still works on windows after this fix.

@rachel-fenichel rachel-fenichel requested a review from a team as a code owner October 28, 2022 22:25
@github-actions github-actions bot added the PR: fix Fixes a bug label Oct 28, 2022
@rachel-fenichel rachel-fenichel merged commit e1244e5 into google:develop Oct 28, 2022
@rachel-fenichel rachel-fenichel deleted the fix_generator_test branch October 28, 2022 22:31
@cpcallen cpcallen mentioned this pull request Oct 28, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants