Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't quote fromJson property. #6545

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix: Don't quote fromJson property. #6545

merged 1 commit into from
Oct 14, 2022

Conversation

NeilFraser
Copy link
Contributor

This is the only place in our codebase where it's quoted. The result is a failure to compile correctly using advanced optimizations.

This is the only place in our codebase where it's quoted.  The result is a failure to compile correctly using advanced optimizations.
@NeilFraser NeilFraser requested a review from a team as a code owner October 14, 2022 11:47
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 14, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@NeilFraser NeilFraser merged commit 5a23c84 into develop Oct 14, 2022
@NeilFraser NeilFraser deleted the fraser-fromJson branch October 14, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants