Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
General code cleanup.
Proposed Changes
Stop using underscores for private fields and methods in
block_drag_surface.ts
andbubble.ts
. Where possible, remove casts and!
markers.Behavior Before Change
No change.
Behavior After Change
No change.
Reason for Changes
General code cleanup: standardize on non-underscored private variable names, and avoid casts so the compiler can better tell us when we make a breaking change.
Test Coverage
Mocha tests, and manual testing:
Documentation
None.
Additional Information
This change was made possible by knowing which properties are private and which are public!
I did not touch anything that's protected.