Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up some underscores #6492

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

General code cleanup.

Proposed Changes

Stop using underscores for private fields and methods in block_drag_surface.ts and bubble.ts. Where possible, remove casts and ! markers.

Behavior Before Change

No change.

Behavior After Change

No change.

Reason for Changes

General code cleanup: standardize on non-underscored private variable names, and avoid casts so the compiler can better tell us when we make a breaking change.

Test Coverage

Mocha tests, and manual testing:

  • Open up the playground and get a block with a mutator.
  • Drag the mutator around by various parts of the bubble (check for no change in bubble behaviour)
  • Add multiple blocks and drag them around the workspace, singly and connected (check for no changes in block drag surface).

Documentation

None.

Additional Information

This change was made possible by knowing which properties are private and which are public!
I did not touch anything that's protected.

@rachel-fenichel rachel-fenichel merged commit a9b0b19 into google:develop Oct 11, 2022
@rachel-fenichel rachel-fenichel deleted the remove_underscores branch October 11, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants