Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update uncompiled-mode dependency loading for playground, tests #5715

Merged
merged 3 commits into from
Nov 17, 2021
Merged

refactor: Update uncompiled-mode dependency loading for playground, tests #5715

merged 3 commits into from
Nov 17, 2021

Commits on Nov 16, 2021

  1. chore: rename module Blockly.blocks.Lists to ....lists 

    All the other Blockly.blocks modules have lower-case names.  This
one being named with an upper-case initial appears to have been a
typo on my part.

This module name is not mentioned anywhere else in the source code
(though it will be soon!) so no other files need to be edited.
Further, it does not appear anywhere in the last release (which
before PR google#5696) so it is not necessary to add an entry in
renamings.js for this change.
    @cpcallen
    cpcallen committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    13638d6 View commit details
    Browse the repository at this point in the history

  2. chore(build): Rationalise deps.js, deps.mocha.js 

    * Include blocks/*.js (Blockly.blocks.*) in tests/deps.js, since
  these modules are used in the playground.  (They are goog.provide
  modules loaded via <script> tags, so their absence from deps.js
  does not cause errors - but it will when they are migrated to
  goog.module and must be loaded via goog.require.)

* Filter the entries in deps.mocha.js so that it includes only the
  additional mocha test modules (i.e. those not mentioned in deps.js
  already).
    @cpcallen
    cpcallen committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    f439466 View commit details
    Browse the repository at this point in the history

  3. refactor: Load blocks and generators using goog.require

    @cpcallen
    cpcallen committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b6a9300 View commit details
    Browse the repository at this point in the history