feat: add serialization of child blocks #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
requested review from
maribethb and
alschmiedt
and removed request for
cpcallen
3 tasks
BeksOmega
commented
Jul 27, 2021
core/serialization/blocks.js
Outdated
| { | ||
| addCoordinates = false, | ||
| addInputBlocks = true, | ||
| addNextBlocks = false |
There was a problem hiding this comment.
It may be better to set this to true by default. Not sure.
There was a problem hiding this comment.
Hmm, what was the original reasoning for defaulting to false here?
My original assumption was that addNextBlocks would be true, but I am not sure I have a great reason for it.
There was a problem hiding this comment.
Originally it was because I thought there were a lot of internal things in Blockly that used this behavior. But it turns out it's just copy paste, and everything else wants next blocks. I'll switch it over to true by default.
alschmiedt
approved these changes
Jul 29, 2021
core/serialization/blocks.js
Outdated
| { | ||
| addCoordinates = false, | ||
| addInputBlocks = true, | ||
| addNextBlocks = false |
There was a problem hiding this comment.
Hmm, what was the original reasoning for defaulting to false here?
My original assumption was that addNextBlocks would be true, but I am not sure I have a great reason for it.
BeksOmega
force-pushed
the
cereal/connnected-blocks
branch
from
607d0e8 to
703decb
Compare
BeksOmega
changed the title
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Sep 13, 2021
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
BeksOmega
added a commit
that referenced
this pull request
Sep 17, 2021
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
alschmiedt
pushed a commit
to alschmiedt/blockly
that referenced
this pull request
Sep 20, 2021
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
alschmiedt
pushed a commit
that referenced
this pull request
Sep 20, 2021
* Add tests for serializing connected blocks * Add serialization of child blocks * Add tests for not serializing children * Add options for not serializing children * Fix types * Change addNextBlocks to default to true * Cleanup * Fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
Link for Diff: BeksOmega/blockly@cereal/field-upgrades...BeksOmega:cereal/connnected-blocks
The details
Resolves
Work on project cereal
Dependent on #5077
Proposed Changes
Adds support for serializing children of a block.
Does not handle deserialization.
Reason for Changes
Saving state is good.
Test Coverage
Added tests for:
saveie do save or don't save.