-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade fields to use new JSO hooks #5077
feat: upgrade fields to use new JSO hooks #5077
Conversation
7f74bb7
to
a6958ae
Compare
@maribethb I'd like your opinion on this:
Do you think it's better lo leave them in or remove them? |
@alschmiedt are you cool with leaving the explicit implementations in? or do you think it's better to pull them? See this comment.
|
I think it is fine in the interim while we are still trying to figure out the best story for backwards compatibility. However, I would add this to the list of things to revisit before releasing. My only problem with keeping it in is we are essentially duplicating this code everywhere, so any change to saveState and loadState would have to be updated in every field. |
Cool cool, I've added that to my task backlog. I'll get this moved to |
* Upgrade field angle to use new serialization * Upgrade field checkbox to use new serialization * Upgrade field colour to use new serialization * Upgrade field dropdown to use new serialization * Upgrade serializable label field to use new serialization * Upgrade field multiline input to use new serialization * Upgrade field number to use new serialization * Upgrade field text input to use new serialization * Upgrade variable field to use new serialization * Fix type casts * Feedback from PR * Switch to use getValue()
* Upgrade field angle to use new serialization * Upgrade field checkbox to use new serialization * Upgrade field colour to use new serialization * Upgrade field dropdown to use new serialization * Upgrade serializable label field to use new serialization * Upgrade field multiline input to use new serialization * Upgrade field number to use new serialization * Upgrade field text input to use new serialization * Upgrade variable field to use new serialization * Fix type casts * Feedback from PR * Switch to use getValue()
* Upgrade field angle to use new serialization * Upgrade field checkbox to use new serialization * Upgrade field colour to use new serialization * Upgrade field dropdown to use new serialization * Upgrade serializable label field to use new serialization * Upgrade field multiline input to use new serialization * Upgrade field number to use new serialization * Upgrade field text input to use new serialization * Upgrade variable field to use new serialization * Fix type casts * Feedback from PR * Switch to use getValue()
* Upgrade field angle to use new serialization * Upgrade field checkbox to use new serialization * Upgrade field colour to use new serialization * Upgrade field dropdown to use new serialization * Upgrade serializable label field to use new serialization * Upgrade field multiline input to use new serialization * Upgrade field number to use new serialization * Upgrade field text input to use new serialization * Upgrade variable field to use new serialization * Fix type casts * Feedback from PR * Switch to use getValue()
The basics
Link for Diff: BeksOmega/blockly@cereal/field-serialiation...BeksOmega:cereal/field-upgrades
The details
Resolves
Work on project cereal
Dependent on #5072
Proposed Changes
Adds implementations of the new JSO serialization hooks to all of the built-in fields. Fields in blockly-samples will be handled later.
Behavior Before Change
Behavior After Change
Reason for Changes
Test Coverage
Added basic tests to ensure that fields serialize correctly. More edge cases are handled by the round-trip serializer tests.