-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for undefined in vertical flyout layout function #7523
Labels
ghc-osd
Reserved for open source day: https://anitab-org.github.io/open-source-day/
issue: bug
Describes why the code or behaviour is wrong
Comments
rachel-fenichel
added
issue: bug
Describes why the code or behaviour is wrong
issue: triage
Issues awaiting triage by a Blockly team member
rrf-internal
labels
Sep 22, 2023
BeksOmega
added
ghc-osd
Reserved for open source day: https://anitab-org.github.io/open-source-day/
and removed
rrf-internal
labels
Sep 22, 2023
Hi @rachel-fenichel, I'd like to work on this issue! |
Hi @rachel-fenichel , I would like to work on this issue. Could you please assign it to me? |
Hi @rachel-fenichel , I would like to work on this issue. |
Hi all, and thanks for your interest! This is being worked on in the |
1 task
maribethb
removed
the
issue: triage
Issues awaiting triage by a Blockly team member
label
Sep 27, 2023
1 task
github-project-automation
bot
moved this from Needs Testing
to Done Coding
in Blockly GHC OSD
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ghc-osd
Reserved for open source day: https://anitab-org.github.io/open-source-day/
issue: bug
Describes why the code or behaviour is wrong
Check for duplicates
Description
In
layout_
inflyout_vertical.ts
we access the block withconst block = item.block
. The result is nullable, so all later uses ofblock
have to have a non-null assertionTo fix:
block
isundefined
after settingconst block = item.block
.continue
ifblock
doesn't exist.!
from after the remaining uses ofblock
within the for loop.Related to #7522
To get set up for this issue:
npm install
from the root of the repository.npm run build
from the root of the repository.npm run start
from the root of the repository to launch the test playground.The text was updated successfully, but these errors were encountered: