Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for undefined in vertical flyout layout function #7523

Closed
1 task done
rachel-fenichel opened this issue Sep 22, 2023 · 4 comments · Fixed by #7536
Closed
1 task done

Check for undefined in vertical flyout layout function #7523

rachel-fenichel opened this issue Sep 22, 2023 · 4 comments · Fixed by #7536
Assignees
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ issue: bug Describes why the code or behaviour is wrong

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Sep 22, 2023

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

In layout_ in flyout_vertical.ts we access the block with const block = item.block. The result is nullable, so all later uses of block have to have a non-null assertion

To fix:

  • Check whether block is undefined after setting const block = item.block.
  • continue if block doesn't exist.
  • Remove ! from after the remaining uses of block within the for loop.

Related to #7522

To get set up for this issue:

  • Run npm install from the root of the repository.
  • Run npm run build from the root of the repository.
  • Run npm run start from the root of the repository to launch the test playground.
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member rrf-internal labels Sep 22, 2023
@BeksOmega BeksOmega added ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ and removed rrf-internal labels Sep 22, 2023
@ivalkshfoeif
Copy link
Contributor

Hi @rachel-fenichel, I'd like to work on this issue!

@rashmi29
Copy link
Contributor

Hi @rachel-fenichel , I would like to work on this issue. Could you please assign it to me?

@11aparna91
Copy link

Hi @rachel-fenichel , I would like to work on this issue.

@rachel-fenichel
Copy link
Collaborator Author

Hi all, and thanks for your interest! This is being worked on in the blockly-elephant breakout room.

@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Sep 27, 2023
@maribethb maribethb linked a pull request Sep 27, 2023 that will close this issue
1 task
@BeksOmega BeksOmega moved this to Done Coding in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Done Coding to Needs Testing in Blockly GHC OSD Sep 29, 2023
@github-project-automation github-project-automation bot moved this from Needs Testing to Done Coding in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Done Coding to Needs Testing in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Needs Testing to Done Testing in Blockly GHC OSD Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ issue: bug Describes why the code or behaviour is wrong
Projects
No open projects
Status: Done Testing
Development

Successfully merging a pull request may close this issue.

6 participants