Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closure-make-deps and closure-calculate-chunks #7469

Closed
Tracked by #6858
cpcallen opened this issue Sep 8, 2023 · 0 comments · Fixed by #7473
Closed
Tracked by #6858

Remove closure-make-deps and closure-calculate-chunks #7469

cpcallen opened this issue Sep 8, 2023 · 0 comments · Fixed by #7473

Comments

@cpcallen
Copy link
Contributor

cpcallen commented Sep 8, 2023

Since each chunk is basically just the files in a particular subdirectory (core/, blocks/, generators/*/) we shouldn't need to use closure-calculate-chunks to compute the command line arguments for Closure Compiler—and if we don't need closure-calculate-chunks then we also no longer need closure-make-deps, since the former is the only remaining consumer of the output from the latter.

@cpcallen cpcallen self-assigned this Sep 8, 2023
@cpcallen cpcallen changed the title Try to remove use of closure-calculate-chunks. Remove closure-make-deps and closure-calculate-chunks Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant