Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EdgeHTML support #6339

Closed
2 of 3 tasks
rachel-fenichel opened this issue Aug 12, 2022 · 1 comment
Closed
2 of 3 tasks

Remove EdgeHTML support #6339

rachel-fenichel opened this issue Aug 12, 2022 · 1 comment
Labels
internal External contributions not accepted issue: feature request Describes a new feature and why it should be added type: cleanup

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Aug 12, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

The Edge browser used to use the EdgeHTML browser engine, but has not done so since version 79. Our checks for Edge in useragent.js were actually looking for EdgeHTML. It is now fully deprecated, so we can remove these workarounds.

Describe the solution you'd like

  • Remove uses of userAgent.EDGE in Blockly core.
  • Remove isEdge and EDGE from useragent.ts
  • Remove EdgeHTML workarounds from stripped-down base.js Left in to match upstream base.js

Describe alternatives you've considered

Leave them in. Rejected as extra ongoing maintenance for something that is not used.

Additional context

Inspecting user agent strings is strongly discouraged because they often contain misleading information--for instance, the Edge browser uses the Blink browser engine.

Found while looking into user agent strings for #6336.
@rachel-fenichel rachel-fenichel added the issue: triage Issues awaiting triage by a Blockly team member label Aug 12, 2022
@rachel-fenichel rachel-fenichel mentioned this issue Aug 12, 2022
Merged
4 tasks
@BeksOmega BeksOmega added type: cleanup internal External contributions not accepted PR: feature Adds a feature issue: feature request Describes a new feature and why it should be added and removed issue: triage Issues awaiting triage by a Blockly team member PR: feature Adds a feature labels Aug 16, 2022
@cpcallen
Copy link
Contributor

Remove EdgeHTML workarounds from stripped-down base.js

From a maintenance point of view it is better that the implementations in base-minimal.js be identical to the ones in the upstream Closure-supplied base.js. So until Closure drops support we should not either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal External contributions not accepted issue: feature request Describes a new feature and why it should be added type: cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cpcallen @rachel-fenichel @BeksOmega