Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up tsickle or similar to re-inject annotations for the closure compiler. #5960

Closed
Tracked by #5857
rachel-fenichel opened this issue Feb 25, 2022 · 1 comment
Closed
Tracked by #5857

Set up tsickle or similar to re-inject annotations for the closure compiler. #5960

rachel-fenichel opened this issue Feb 25, 2022 · 1 comment
Labels
component: build process internal External contributions not accepted

Comments

@rachel-fenichel
Copy link
Collaborator

rachel-fenichel commented Feb 25, 2022 •
edited
Loading

I made a gist with the scripts I've used to test tsickle so far.
@rachel-fenichel rachel-fenichel mentioned this issue Feb 25, 2022
Closed
47 tasks
@BeksOmega BeksOmega added component: build process internal External contributions not accepted labels Feb 25, 2022
@rachel-fenichel
Copy link
Collaborator Author

@cpcallen and I discussed this with some folks who work on or with the Closure Compiler internally. They said that tsickle will not work for this case, but that it may be possible to build without type checks or annotations and still get good minified code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: build process internal External contributions not accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rachel-fenichel @BeksOmega