Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test helpers to core #5466

Open
alschmiedt opened this issue Sep 15, 2021 · 0 comments
Open

Move test helpers to core #5466

alschmiedt opened this issue Sep 15, 2021 · 0 comments
Labels
issue: feature request Describes a new feature and why it should be added type: cleanup

Comments

@alschmiedt
Copy link
Contributor

alschmiedt commented Sep 15, 2021

Is your feature request related to a problem? Please describe.

We use test helpers found in dev tools to write tests in core. The fact that we were using an external package was causing pain while trying to do the goog_module conversion because we kept having to release dev-tools to get CI to pass.

Describe the solution you'd like

  • We need to move test helpers out of dev-tools and into core.
  • Test that we can successfully import them from the blockly package.

Describe alternatives you've considered

Additional context

@alschmiedt alschmiedt added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Sep 15, 2021
@alschmiedt alschmiedt added type: cleanup and removed issue: triage Issues awaiting triage by a Blockly team member labels Sep 16, 2021
@alschmiedt alschmiedt added this to the Bug Bash Backlog milestone Sep 16, 2021
@maribethb maribethb self-assigned this Nov 20, 2021
@BeksOmega BeksOmega self-assigned this Feb 28, 2022
@BeksOmega BeksOmega removed their assignment Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: feature request Describes a new feature and why it should be added type: cleanup
Projects
None yet
Development

No branches or pull requests

3 participants