Localization broken in field-date

[frck006]

It's more a question than a bug.
I would like to know how to change the local in @blockly/field-date ?

When I set 'fr', this change "today" but not the month.

Thanks

[cpcallen]

I am pretty sure this is actually a bug.

You don't describe how your code changes the locale, but I added

import * as Fr from 'blockly/msg/fr';
Blockly.setLocale(Fr);

to the top of plugins/field-date/test/index.js (just beneath import * as Blockly…), and was able to reproduce exactly.

I believe the problem is in FieldDate.loadLanguage_:

  static loadLanguage_() {
    for (const prop in goog.i18n) {
      if (prop.startsWith('DateTimeSymbols_')) {
        const lang = prop.substr(16).toLowerCase().replace('_', '.');
        // E.g. 'DateTimeSymbols_pt_BR' -> 'pt.br'
        if (goog.getObjectByName(lang, Blockly.Msg)) {
          goog.i18n.DateTimeSymbols = goog.i18n[prop];
          break;
        }
      }
    }
  }

As far as I can tell this is expecting to find a property named Blockly.Msg.fr(or whatever language has been set) and no such property exists so goog.i18n.DateTimeSymbols is never set.

I'm not really sure how this could ever have worked. Did Blockly.Msg formerly have a property named for the language loaded?

[alicialics]

Looks like the snippet above (ie loadLanguage_() was removed in #1705
Instead of goog.ui.DatePicker() it was replaced with browser's native date picker. However it does mean that the strings won't be localized if the browser locale != Blockly locale.

cc @BeksOmega

[rachel-fenichel]

Is there a way to force the native date picker to use a specific locale by code other than the browser locale?

[rachel-fenichel]

It looks like we don't have a way to force the locale of the date picker. However, if there's a mismatch between Blockly locale and browser locale there's a good chance that the browser locale is the user's actual preferred locale, and that they will understand the month strings that are available. This seems acceptable, given that it allows us to not implement a custom date picker (or import one from elsewhere, as we did with the Closure UI library).