Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exported_plugins doesn't do quite what we want for beta-checker in guava #200

Open
cpovirk opened this issue Nov 7, 2024 · 0 comments
Open
Labels
bug Something isn't working P4

Comments

@cpovirk
Copy link
Member

cpovirk commented Nov 7, 2024

exported_plugins is "The list of java_plugins (e.g. annotation processors) to export to libraries that directly depend on this library." That makes it suitable for plain old annotation processors (since you can't write an annotation in your code without depending directly upon it) and for static analysis that applies to such annotation usages, but it does not make it suitable for cases like ours, "No one calls a @Beta method from Guava," since it's possible to call a @Beta method on Guava without declaring a direct dependency on Guava itself.

The practical danger here is slim, since Guava has few @Beta APIs nowadays. But it might be more honest to remove exported_plugins or to find another way of fully enabling the checking that we want. Really, though, I'm filing this bug because TIL from a question on YAQS :) See also some Google-internal documentation added in CL 149351089 (though the Bazel docs are crystal-clear on the behavior, even if they don't go into the implications in detail).

@cpovirk cpovirk added bug Something isn't working P4 labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4
Projects
None yet
Development

No branches or pull requests

1 participant