Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remove_ignored #383

Closed
adetaylor opened this issue Apr 17, 2021 · 3 comments · Fixed by #384
Closed

Remove remove_ignored #383

adetaylor opened this issue Apr 17, 2021 · 3 comments · Fixed by #384

Comments

@adetaylor
Copy link
Collaborator

adetaylor commented Apr 17, 2021

#288 introduced an analysis pass to remove ignored things (as reported in #288).

I think #373 fixed the root cause, so we should revert #288.

This was referenced Apr 17, 2021
@martinboehme
Copy link
Collaborator

I think this may still be needed -- see draft PR #393 for an example where it's necessary to ignore APIs that use other ignored APIs.

@adetaylor
Copy link
Collaborator Author

Turns out you were right all along - see #453! :)

@martinboehme
Copy link
Collaborator

Interesting! That was entirely down to luck, not insight on my part though. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants