Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle repeated answers in questionnaire validation #487

Closed
stevenckngaa opened this issue May 19, 2021 · 1 comment · Fixed by #1882
Closed

Handle repeated answers in questionnaire validation #487

stevenckngaa opened this issue May 19, 2021 · 1 comment · Fixed by #1882
Assignees
@jingtang10
Labels
type:enhancement New feature or request

Comments

@stevenckngaa
Copy link
Collaborator

The validation framework: only validates the first answer from QuestionnaireResponseItemComponent. Suggest to validate all answers.
@stevenckngaa stevenckngaa added the type:enhancement New feature or request label May 19, 2021
@epicadk epicadk mentioned this issue Oct 24, 2021
Merged
8 tasks
@shoaibmushtaq25 shoaibmushtaq25 mentioned this issue Mar 4, 2022
Merged
7 tasks
@Tarun-Bhardwaj Tarun-Bhardwaj moved this to Backlog in Android FHIR SDK Sep 12, 2022
@jingtang10 jingtang10 mentioned this issue Feb 22, 2023
Merged
7 tasks
@jingtang10
Copy link
Collaborator

jingtang10 commented Feb 22, 2023 •
edited
Loading

this issue should be fixed in the following places:

android-fhir/datacapture/src/main/java/com/google/android/fhir/datacapture/validation/PrimitiveTypeAnswerMaxLengthValidator.kt

Line 37 in a9d95db

// TODO(https://github.com/google/android-fhir/issues/487): Validate all answers.

android-fhir/datacapture/src/main/java/com/google/android/fhir/datacapture/validation/ValueConstraintExtensionValidator.kt

Line 38 in a9d95db

// TODO(https://github.com/google/android-fhir/issues/487): Validates all answers.

@jingtang10 jingtang10 mentioned this issue Feb 22, 2023
Merged
7 tasks
@jingtang10 jingtang10 self-assigned this Feb 23, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Complete in Android FHIR SDK Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jingtang10 jingtang10

Labels
type:enhancement New feature or request
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate all answers in questionnaire response item jingtang10/android-fhir
3 participants
@jingtang10 @stevenckngaa @Tarun-Bhardwaj