Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add questionnaire and qItem as reserved variables #2477

Closed
FikriMilano opened this issue Mar 15, 2024 · 8 comments · Fixed by #2478
Closed

Add questionnaire and qItem as reserved variables #2477

FikriMilano opened this issue Mar 15, 2024 · 8 comments · Fixed by #2478
Assignees
Labels
effort:xsmall Extra small effort - 1 day P2 Medium priority issue type:enhancement New feature or request

Comments

@FikriMilano
Copy link
Collaborator

FikriMilano commented Mar 15, 2024

Describe the Issue
Add questionnaire and qItem as reserved variables.

Note:
Based on this doc, I would argue that qItem is not supposed to be accessed via root level of any expression based extension. BUT still, I don't see the downsides of adding qItem as part of the reserved variables. It's simpler too.

The %qitem variable is defined as a shortcut to get to the Questionnaire.item that corresponds to the context QuestionnaireResponse.item. It is only valid for FHIRPath expressions defined within a Questionnaire item.
https://build.fhir.org/ig/HL7/sdc/expressions.html#fhirpath-supplements

Would you like to work on the issue?
Yes

@FikriMilano
Copy link
Collaborator Author

@jingtang10 @f-odhiambo this is a super small change

@FikriMilano
Copy link
Collaborator Author

@ndegwamartin

@MJ1998
Copy link
Collaborator

MJ1998 commented Mar 15, 2024

@FikriMilano

You mean that, based on doc, qItem can still be used in expression defined at questionnaire root level, right ?

@FikriMilano
Copy link
Collaborator Author

@MJ1998 I meant the opposite

@FikriMilano
Copy link
Collaborator Author

qItem is only valid when used in Questionnaire item

@MJ1998
Copy link
Collaborator

MJ1998 commented Mar 15, 2024

I mean the same. qItem should be a reserved item in Questionnaire items. But from definition, one should be able to use it as a variable name (not recognized as a reserved word) when declared in the questionnaire root extension(s), correct ?

But from code this will be considered as a reserved word for root level extensions as well.

@FikriMilano
Copy link
Collaborator Author

@MJ1998 correct and correct.
Let me know if you or anyone have objections to that.

@MJ1998
Copy link
Collaborator

MJ1998 commented Mar 15, 2024

Supporting this will also not be a big change but it's not needed currently.
I am fine with it. @jingtang10

@MJ1998 MJ1998 added type:enhancement New feature or request P2 Medium priority issue effort:xsmall Extra small effort - 1 day labels Mar 15, 2024
@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:xsmall Extra small effort - 1 day P2 Medium priority issue type:enhancement New feature or request
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants