Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The visual of the bottom-rightmost button is getting cut off. #2404

Closed
santosh-pingle opened this issue Jan 9, 2024 · 4 comments · Fixed by #2407
Closed

The visual of the bottom-rightmost button is getting cut off. #2404

santosh-pingle opened this issue Jan 9, 2024 · 4 comments · Fixed by #2407
Assignees
Labels
P1 High priority issue

Comments

@santosh-pingle
Copy link
Collaborator

Describe the bug
When the Cancel button is configured, the rightmost button at the bottom gets partially cut off in the paginated layout.

Component
SDC library

To Reproduce
Steps to reproduce the behavior:

  1. Configure the Cancel button.
  2. Open the paginated layout questionnaire.
  3. Click the Next button until the page reaches the last page.
  4. Observe the appearance of buttons at the bottom.

Expected behavior
The buttons should not be cut off; the user should be able to scroll the bottom view horizontally to see the buttons.

Screenshots
Screenshot 2024-01-09 at 12 48 32

Smartphone (please complete the following information):

  • Device: Pixel2a
  • Android version: 12

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle
Copy link
Collaborator Author

looking into it.

@santosh-pingle
Copy link
Collaborator Author

santosh-pingle commented Jan 10, 2024

  1. One approach is to add a HorizontalScrollView, allowing users to scroll and view partially hidden buttons. In this case, disabled buttons can also be shown.

  2. Alternatively, you can choose to hide the disabled buttons, ensuring enough space for other buttons to be rendered on the screen. Hide previous and next button #2397

@jingtang10
Copy link
Collaborator

i think scrollable bottom view is not ideal.

suggestions:

  1. can we always hide the next button when there's submit button? or always hide it on the last page?
  2. the margins between these buttons are huge. can we reduce them. please make sure this is aligned with the material guidelines.
  3. can we make the cancel button border-less. it seems very large for what it is

@jingtang10
Copy link
Collaborator

@shelaghm fyi

@santosh-pingle santosh-pingle added the P1 High priority issue label Jan 15, 2024
@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants