Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ExpressionEvaluator to evaluate expressions more generically #2094

Closed
MJ1998 opened this issue Jul 22, 2023 · 2 comments · Fixed by #2132
Closed

Refactor ExpressionEvaluator to evaluate expressions more generically #2094

MJ1998 opened this issue Jul 22, 2023 · 2 comments · Fixed by #2132
Assignees
@MJ1998
Labels
P2 Medium priority issue type:code health

Comments

@MJ1998
Copy link
Collaborator

MJ1998 commented Jul 22, 2023

Describe the Issue
Same logic in fn:evaluateExpression is being used in fn:evaluateQuestionnaireItemVariableExpression and fn:createXFhirQueryFromExpression as well (post PR 2066 merges).
Additionally the cqfExpression should also support xFhirQuery language [source]. So resolving expressions could become more generic and there need not be different functions like resolveCqfExpression and resolveAnswerExpression.

Would you like to work on the issue?
Yes
@MJ1998 MJ1998 mentioned this issue Jul 22, 2023
Merged
7 tasks
@santosh-pingle santosh-pingle added type:code health P2 Medium priority issue labels Jul 24, 2023
@MJ1998 MJ1998 mentioned this issue Sep 8, 2023
Merged
7 tasks
@FikriMilano
Copy link
Collaborator

thanks @MJ1998

@FikriMilano
Copy link
Collaborator

@f-odhiambo by accident, I'm actually working on this in PR #2132

@jingtang10 jingtang10 linked a pull request Sep 8, 2023 that will close this issue
enable when expression can access variable #2132
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJ1998 MJ1998

Labels
P2 Medium priority issue type:code health
Projects
Android FHIR SDK
Status: Complete
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enable when expression can access variable opensrp/android-fhir
3 participants
@MJ1998 @FikriMilano @santosh-pingle