Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of fhirPathEngine in Utils should be centralized and made consistent #1993

Closed
maimoonak opened this issue Apr 27, 2023 · 2 comments
Closed
Labels
type:enhancement New feature or request

Comments

@maimoonak
Copy link
Collaborator

Describe the bug
As per discussion here #1957 (comment) the fhirPathEngine usage should be centralized and made consistent throughout app. There are usages in ExpressionEvaluator, QuestionnaireViewModel and ResourceMapper which should be modified so that all expressions evaluated are passed with corresponding context data consistently.

Component
SDC library

@santosh-pingle
Copy link
Collaborator

@maimoonak
Is it okay to add code health label?

@omarismail94
Copy link
Contributor

I think this is resolved now. We only have one fhirPathEngine in FhirPathUtil that gets passed around in the different classes in datacapture. If this is not true, feel free to re-open the issue

@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
Status: Complete
Development

No branches or pull requests

3 participants