Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fhirpath supplement context literal #1958

Closed
maimoonak opened this issue Apr 6, 2023 · 1 comment · Fixed by #1957
Closed

Support fhirpath supplement context literal #1958

maimoonak opened this issue Apr 6, 2023 · 1 comment · Fixed by #1957
Assignees
Labels
effort:medium Medium effort - 3 to 5 days P1 High priority issue type:enhancement New feature or request

Comments

@maimoonak
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
To make question fhirpath dynamic and have current questionnaire item we need to support fhirpath supplement context literal. This allow to get current questionnaire item as %context into fhirpath expressions on questionnaire items. Details for spec defined here https://build.fhir.org/ig/HL7/sdc/expressions.html#fhirpath-supplements .

Describe the solution you'd like
An implementation exists in PR #1957 . This has a catalog implementation as an example as well. The enableWhen evaluate method passes the questionnaireResponseItem when calling evaluate for expression.

Additional context
This is a bug fix and the changes MAY affect existing use of enableWhenExpression where anyone tried to write expression for questionnaireResponse as $this. $this refers to current item under consideration aka %context as well. Old implementation might have entertained $this as questionnaireResponse. Hence anyone using expression wrongfully can have erratic behavior for their current enableWhenExpressions

Would you like to work on the issue?
Done in PR #1957

@jingtang10 jingtang10 added the type:enhancement New feature or request label Apr 24, 2023
@jingtang10 jingtang10 changed the title Enable when expression fhirpath should support fhirpath supplement context literal Support fhirpath supplement context literal Apr 24, 2023
@jingtang10
Copy link
Collaborator

Updated the issue title since this should not be limited to enable when expression -> this should be available to all fhir path expressions in a questionnaire.

@jingtang10 jingtang10 added P1 High priority issue effort:medium Medium effort - 3 to 5 days labels Apr 24, 2023
@jingtang10 jingtang10 self-assigned this Apr 24, 2023
@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Medium effort - 3 to 5 days P1 High priority issue type:enhancement New feature or request
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants