Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Android Min API Level 24 #1628

Closed
jingtang10 opened this issue Sep 23, 2022 · 4 comments · Fixed by #1629
Closed

Support Android Min API Level 24 #1628

jingtang10 opened this issue Sep 23, 2022 · 4 comments · Fixed by #1629
Labels
type:process Create or improve processes
Milestone
Data Capture Libr...

Comments

@jingtang10
Copy link
Collaborator

We have not been testing API level 21 consistently in our testing matrix: https://github.com/google/android-fhir/blob/master/.github/workflows/device-tests.yml#L40

We should consider raising the min api level to 24 (released aug 2016) as we already do not guarantee support for anything lower than 24 due to our lack of tests.
@jingtang10 jingtang10 added the type:process Create or improve processes label Sep 23, 2022
@jingtang10 jingtang10 mentioned this issue Sep 23, 2022
Open
@jingtang10
Copy link
Collaborator Author

Discussed with @joiskash @pld offline.

FYI also @fredhersch @f-odhiambo @mberg @ekigamba @maimoonak @kunjan8794 since this is an important change

@jingtang10
Copy link
Collaborator Author

@vitorpamplona

@jingtang10 jingtang10 mentioned this issue Sep 23, 2022
Merged
7 tasks
@jingtang10
Copy link
Collaborator Author

Have discussed this offline with @pld, @joiskash and no concern is raised.

@jingtang10
Copy link
Collaborator Author

See #1627 for more details and background regarding api level change for the workflow library

@Tarun-Bhardwaj Tarun-Bhardwaj moved this from New to Complete in Android FHIR SDK Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:process Create or improve processes
Projects
Android FHIR SDK
Status: Complete
Milestone
Data Capture Library 0.1.0-beta06
Development

Successfully merging a pull request may close this issue.

Support Android API Level 24+ jingtang10/android-fhir
2 participants
@jingtang10 @Tarun-Bhardwaj