Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook magic test broken by python 3.12.5 release. #520

Closed
MarkDaoust opened this issue Aug 22, 2024 · 0 comments · Fixed by #521
Closed

Notebook magic test broken by python 3.12.5 release. #520

MarkDaoust opened this issue Aug 22, 2024 · 0 comments · Fixed by #521
Labels
type:bug Something isn't working

Comments

@MarkDaoust
Copy link
Collaborator

Description of the bug:

https://docs.python.org/3/whatsnew/changelog.html

gh-121018: Fixed issues where argparse.ArgumentParser.parse_args() did not honor exit_on_error=False. Based on patch by Ben Hsing.

We set exit_on_error=False, but then patch exit to throw a custom exception, catch it, and raise SystemExit (?).

One test is failing, blocking PRs.

Actual vs expected behavior:

Test should pass.

Any other information you'd like to share?

No response

@MarkDaoust MarkDaoust added the type:bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant