Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Github release script #110

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix Github release script #110

merged 1 commit into from
Apr 22, 2024

Conversation

hsubox76
Copy link
Collaborator

Trigger on all tag pushes. We should only be pushing tags on releases but I added a conditional on the job to make sure the tag matches the pattern.

@hsubox76 hsubox76 marked this pull request as ready for review April 22, 2024 19:59
@hsubox76 hsubox76 requested a review from lahirumaramba April 22, 2024 19:59
lahirumaramba
lahirumaramba approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@hsubox76 hsubox76 merged commit 743b801 into main Apr 22, 2024
3 checks passed
@hsubox76 hsubox76 deleted the ch-gh-release-2 branch April 22, 2024 22:33
@Anomaly-1 Anomaly-1 mentioned this pull request May 20, 2024
Open
@leoo1992 leoo1992 mentioned this pull request May 21, 2024
Merged
@cnkang cnkang mentioned this pull request May 22, 2024
Closed
@leoo1992 leoo1992 mentioned this pull request May 24, 2024
Merged
@nestorzamili nestorzamili mentioned this pull request May 24, 2024
Closed
@gaohongwei11 gaohongwei11 mentioned this pull request May 25, 2024
Open
@cnkang cnkang mentioned this pull request May 25, 2024
Merged
@Anomaly-1 Anomaly-1 mentioned this pull request May 25, 2024
Open
@gaohongwei11 gaohongwei11 mentioned this pull request May 25, 2024
Open
@nestorzamili nestorzamili mentioned this pull request May 30, 2024
Merged
@gaohongwei11 gaohongwei11 mentioned this pull request May 30, 2024
Open
This was referenced May 30, 2024
Open
Open
@Anomaly-1 Anomaly-1 mentioned this pull request Jun 7, 2024
Open
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
This was referenced Jun 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsubox76 @lahirumaramba