Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to base R #27

Merged
merged 17 commits into from
Sep 13, 2023
Merged

Move to base R #27

merged 17 commits into from
Sep 13, 2023

Conversation

gongcastro
Copy link
Owner

  • Switch most functions to base R. I made this decision in order to learn R base a bit better. Performance differences are negligible, and the user interface remains the same.
  • Phonology functions and datasets have been removed, and will be included in a different package.
  • bvq_vocabulary() now has a better naming system.

@gongcastro gongcastro added items item types, labels, vlaues or options. feature a feature request or enhancement labels Sep 13, 2023
@gongcastro gongcastro self-assigned this Sep 13, 2023
@gongcastro
Copy link
Owner Author

NAMESPACE is not updated. Phonology functions (now removed from the package) are expected but not found.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 98.30% and project coverage change: -0.58% ⚠️

Comparison is base (97ae604) 94.81% compared to head (601a3b2) 94.24%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   94.81%   94.24%   -0.58%     
==========================================
  Files           7        5       -2     
  Lines         193      191       -2     
==========================================
- Hits          183      180       -3     
- Misses         10       11       +1     
Files Changed Coverage Δ
R/utils.R 90.47% <90.47%> (+0.47%) ⬆️
R/logs.R 95.74% <100.00%> (ø)
R/norms.R 91.11% <100.00%> (-2.51%) ⬇️
R/vocabulary.R 96.05% <100.00%> (+0.97%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gongcastro
Copy link
Owner Author

Logo is missing from man/figures/ folder. Run inst/utils/logo/R.

@gongcastro
Copy link
Owner Author

Lost some code coverage (mostly bvq_norms()) but should be good to go.

@gongcastro gongcastro merged commit b518b9f into main Sep 13, 2023
8 of 9 checks passed
@gongcastro gongcastro deleted the v0.4.0 branch May 29, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement items item types, labels, vlaues or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant