Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include docker-compose launch in the test runner #291

Closed
8 of 9 tasks
kmazurek opened this issue Sep 15, 2020 · 0 comments · Fixed by #292
Closed
8 of 9 tasks

Include docker-compose launch in the test runner #291

kmazurek opened this issue Sep 15, 2020 · 0 comments · Fixed by #292
Assignees
Labels
enhancement New feature or request

Comments

@kmazurek
Copy link
Contributor

kmazurek commented Sep 15, 2020

Subtasks:

Compose:

  • provide a way for specifying custom compose files
  • create a manager module for docker-compose
  • re-use already built images (conditional --build flag on docker-compose)
  • address original review comments

GH Actions:

  • update integration Actions workflow
  • provide GitHub token through an env variable

Misc:

  • add printing a list of running containers and network info
  • update README

Optional:

  • wait for specific log lines in compose containers

In the current setup, running integration tests requires a docker-compose network to be started beforehand. This external dependency introduces unnecessary complexity to the test flow.
This can be simplified by managing docker-compose by the test harness runner itself (see test integration workflow for steps which are performed before a test run).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants