Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution #15

Closed
ccoVeille opened this issue Apr 18, 2024 · 3 comments
Closed

Contribution #15

ccoVeille opened this issue Apr 18, 2024 · 3 comments
Labels
question Further information is requested

Comments

@ccoVeille
Copy link

I would like to thank you for maintaining golangci-lint, and took the decision to keep misspell maintained.

Thank you also for adding a way to provide a way for handing "correction" via golangci mispell linter via extra-words via golangci/golangci-lint#4401

It would help people in doing things by their own.

By trying to achieve it on my project, I noticed a few things that I think that should be added to misspell.

I'm thinking about adding a few more item in DictAmerican (and so DictBritish) that are meaningful in Go ecosystem:

Here are a few examples

Here is marshalling conversion

misspell/words.go

Line 28977 in 950f5d1

"marshalled", "marshaled",

I would like to add things like:

  • marshaller <-> marshaller
  • everything needed to support unmarshal* (currently not detected)

Tell me if you are interested, the changes are pretty small, but I prefer to ask before working on it, and getting a "no", during the review 😄

@ldez
Copy link
Member

ldez commented Apr 18, 2024

Hello,

The list is generated based on usage frequency and different sources.

For now, I don't plan to change that (because it's the main approach of misspell design) to add extra words inside misspell, this is why I created extra-words inside golang-ci lint and not add words inside misspell.

@ldez ldez added the question Further information is requested label Apr 18, 2024
@ccoVeille
Copy link
Author

OK.

My point is that words.go wasn't updated for a while.

Thanks for replying me.

I'm closing this issue.

@ccoVeille ccoVeille closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
@silverwind
Copy link

The list is generated based on usage frequency and different sources.

Where is the source of this generation and are contributions welcome there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants