build(deps): bump github.com/nunnatsa/ginkgolinter from 0.17.0 to 0.1…

…8.0 (#5114)

Co-authored-by: Fernandez Ludovic <[email protected]>

.golangci.next.reference.yml

@@ -652,6 +652,10 @@ linters-settings:
     # Default: false
     forbid-spec-pollution: true
 
+    # Force using the Succeed matcher for error functions, and the HaveOccurred matcher for non-function error values.
+    # Default: false
+    force-succeed: true
+
   gochecksumtype:
     # Presence of `default` case in switch statements satisfies exhaustiveness, if all members are not listed.
     # Default: true

go.mod

@@ -82,7 +82,7 @@ require (
 	github.com/nakabonne/nestif v0.3.1
 	github.com/nishanths/exhaustive v0.12.0
 	github.com/nishanths/predeclared v0.2.2
-	github.com/nunnatsa/ginkgolinter v0.17.0
+	github.com/nunnatsa/ginkgolinter v0.18.0
 	github.com/pelletier/go-toml/v2 v2.2.3
 	github.com/polyfloyd/go-errorlint v1.6.0
 	github.com/quasilyte/go-ruleguard/dsl v0.3.22

jsonschema/golangci.next.jsonschema.json

@@ -1180,6 +1180,11 @@
               "description": "Trigger a warning for variable assignments in ginkgo containers like `Describe`, `Context` and `When`, instead of in `BeforeEach()`.",
               "type": "boolean",
               "default": false
+            },
+            "force-succeed": {
+              "description": "Force using the Succeed matcher for error functions, and the HaveOccurred matcher for non-function error values.",
+              "type": "boolean",
+              "default": false
             }
           }
         },

pkg/config/linters_settings.go

@@ -488,6 +488,7 @@ type GinkgoLinterSettings struct {
 	ForceExpectTo              bool `mapstructure:"force-expect-to"`
 	ValidateAsyncIntervals     bool `mapstructure:"validate-async-intervals"`
 	ForbidSpecPollution        bool `mapstructure:"forbid-spec-pollution"`
+	ForceSucceedForFuncs       bool `mapstructure:"force-succeed"`
 }
 
 type GoChecksumTypeSettings struct {

pkg/golinters/ginkgolinter/ginkgolinter.go

@@ -25,6 +25,7 @@ func New(settings *config.GinkgoLinterSettings) *goanalysis.Linter {
 			ForceExpectTo:          types.Boolean(settings.ForceExpectTo),
 			ValidateAsyncIntervals: types.Boolean(settings.ValidateAsyncIntervals),
 			ForbidSpecPollution:    types.Boolean(settings.ForbidSpecPollution),
+			ForceSucceedForFuncs:   types.Boolean(settings.ForceSucceedForFuncs),
 		}
 	}