Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a skip-go-installation to use pre-installed Go #144

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Add a skip-go-installation to use pre-installed Go #144

merged 2 commits into from
Dec 31, 2020

Conversation

SVilgelm
Copy link
Member

@SVilgelm SVilgelm commented Dec 29, 2020 •
edited
Loading

Add a skip-go-installation parameter in action. If it is set to true, the pre-installed go is used
Add the golangci-lint binary to PATH

closes #75

@SVilgelm SVilgelm mentioned this pull request Dec 29, 2020
Closed
@SVilgelm SVilgelm force-pushed the fix-75 branch 3 times, most recently from cab0a64 to 856e970 Compare December 29, 2020 03:10
@SVilgelm
Copy link
Member Author

Here is the version that installs latest go: https://github.com/sv-tools/bumptag/pull/64/checks?check_run_id=1620020838
Here is using the skip-go-installation parameter: https://github.com/sv-tools/bumptag/pull/64/checks?check_run_id=1620045798

@SVilgelm SVilgelm force-pushed the fix-75 branch 5 times, most recently from 3747c11 to 9c113bc Compare December 29, 2020 03:44
@SVilgelm
Copy link
Member Author

@golangci/team @golangci/core-team Please review

magnetikonline
magnetikonline reviewed Dec 29, 2020
View reviewed changes
action.yml Outdated Show resolved Hide resolved
@SVilgelm SVilgelm requested review from a team December 29, 2020 04:31
Add skip-go-installation to use pre-installed Go
7c6389e 
Add the golangci-lint to PATH
@SVilgelm
Copy link
Member Author

Did an incorrect rebase and had to restore the changes :)

@SVilgelm SVilgelm changed the title Do not install go if it is already installed Add a skip-go-installation to use pre-installed Go Dec 29, 2020
@SVilgelm
Copy link
Member Author

@golangci/team please review the PR

@SVilgelm
Copy link
Member Author

@golangci/team ping ping

ldez
ldez approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SVilgelm SVilgelm merged commit e4e910b into master Dec 31, 2020
@SVilgelm SVilgelm deleted the fix-75 branch December 31, 2020 17:21
@SVilgelm SVilgelm mentioned this pull request Feb 14, 2021
Merged
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
@ldez ldez added the enhancement New feature or request label Apr 4, 2021
@negz negz mentioned this pull request Apr 20, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@magnetikonline magnetikonline Awaiting requested review from magnetikonline

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to specify Go version
3 participants
@SVilgelm @magnetikonline @ldez