Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: remote debugging skips shutting down ProtocolServer #764

Closed
polinasok opened this issue Oct 9, 2020 · 1 comment
Closed

debug: remote debugging skips shutting down ProtocolServer #764

polinasok opened this issue Oct 9, 2020 · 1 comment
Assignees
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone

Comments

@polinasok
Copy link
Contributor

We should see the following logging at the end of a debug session as it calls super.disconnectRequest:

DisconnectRequest to parent
DisconnectResponse

These do not show up in remote logs because in that case close() returns without resolving a promise (code), so the rest of the exit code awaits. Vscode just has a disconnect timeout, but according to @quoctruong, Theia does not.

@polinasok polinasok added the Debug Issues related to the debugging functionality of the extension. label Oct 9, 2020
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/257337 mentions this issue: debugAdapter: Fix bugs that cause remote debug to hang

@hyangah hyangah added this to the v0.18.0 milestone Oct 21, 2020
@golang golang locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants