Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Github CI at master, with older go versions (<go1.23) is broken #3516

Closed
hyangah opened this issue Aug 30, 2024 · 1 comment
Closed

ci: Github CI at master, with older go versions (<go1.23) is broken #3516

hyangah opened this issue Aug 30, 2024 · 1 comment
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 30, 2024

After marking the extension module's go version to go1.23.0 in CL 595376, they are broken.

The root cause is golang/go#68005

Some of our script programs invoke go run and the command go sets GOROOT, but doesn't adjust PATH.
So, CI ended up facing mismatched go and GOROOT setting.

The easiest fix is to downgrade the go.mod lang version, and build the release tool (that requires go1.23) only with go1.23 (buildtag)

@gopherbot gopherbot added this to the Untriaged milestone Aug 30, 2024
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/609276 mentions this issue: extension: lower the go version in go.mod

@hyangah hyangah modified the milestones: Untriaged, v0.44.0 Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants