-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'remote' mode with 'dlv-dap' debugAdapter must connect to an external dlv --headless
server @ v1.7.3 or later
#2018
Comments
@tekumara Can you start the remote debug server with logging enabled ( |
No problem, here are the logs: dlv debug --headless --listen=:12345 --log --log-output=rpc,dap,debugger
|
Thanks @tekumara |
Yep - debugging works but the popup is spurious. |
This pop-up is not an error. It is informational and was designed to let the users know that they were switching to using dlv-dap for remote, which was previously always using legacy. We don't have a way to tell what version the remote server is, so this was triggered in all cases just in case the user stumbled into the dlv-dap remote mode by accident. The idea was that once the user confirms their set-up, they could just disable with "Don't Show Again" and never see this again. |
Sorry, posted before I was done typing. We realized that this could be confusing and interpreted as an error, so we tweaked the wording - see #1945 (comment), but this unfortunately didn't make it into the current release. Our plan was to remove the start-up warning once the user community was aware of the dlv-dap remote mode. |
@polinasok I suspect there is a bug that caused this popup show (maybe a race?) even when the remote debugging using dlv-dap was successful. Edit: Oh, I see. I think this popup is distracting and should use Information (not Warning) if we want to keep this. |
@hyangah No, there is no race, this always shows up on start-up and is working as intended. With nighlty it would still show up, but will be less confusingly worded. Please see #1945. We were in the middle of deciding whether to take it out completely in case users get confused and think it is an error (like they did here), but then the extension got released as-is, and this topic got dropped. |
We had that discussion too: https://go-review.googlesource.com/c/vscode-go/+/371974/1/src/goDebugConfiguration.ts#178 |
Change https://go.dev/cl/391054 mentions this issue: |
What version of Go, VS Code & VS Code Go extension are you using?
Version Information
go version
to get version of Go from the VS Code integrated terminal.gopls -v version
to get version of Gopls from the VS Code integrated terminal.code -v
orcode-insiders -v
to get version of VS Code or VS Code Insiders.Go: Locate Configured Go Tools
command.Share the Go related settings you have added/edited
Describe the bug
This warning pops up, even though I am able to connect and debug:
This warning appeared under dlv 1.7.1. I upgraded to dlv 1.8.0 and it remained.
I expect a warning only if there is an issue that needs to be addressed.
Steps to reproduce the behavior:
dlv debug --headless --listen=:12345
Screenshots or recordings
The text was updated successfully, but these errors were encountered: