Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: pin dlv-dap version #1661

Closed
hyangah opened this issue Aug 3, 2021 · 2 comments
Closed

tools: pin dlv-dap version #1661

hyangah opened this issue Aug 3, 2021 · 2 comments
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Milestone
v0.30.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Aug 3, 2021

Currently, the extension builds dlv-dap from the master branch of delve. Since that is the dev branch, it can be too unstable. Use a pinned version instead.

cc @suzmue @polinasok
@hyangah hyangah added the Debug Issues related to the debugging functionality of the extension. label Aug 3, 2021
@hyangah hyangah added this to the v0.27.0 milestone Aug 3, 2021
@gopherbot gopherbot modified the milestones: v0.27.0, Untriaged Aug 3, 2021
@hyangah hyangah modified the milestones: Untriaged, On Deck Aug 3, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/339449 mentions this issue: src/goInstallTools: pin dlv-dap version @ 89ed5a0b

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/370414 mentions this issue: Revert "src/goInstallTools: unpin dlv-dap version, and pick master"

gopherbot pushed a commit that referenced this issue Dec 8, 2021
@hyangah
src/goInstallTools: pin dlv-dap version @2f136727
27bcdca 
This reverts commit a1cc5e5
(https://go-review.googlesource.com/c/vscode-go/+/344789)

and pins dlv-dap at go-delve/delve@2f13672

We removed pinning in a1cc5e5 because we were still actively developing
Delve DAP and the pinning made it difficult for users to pick up
the latest bug fixes.

Now Delve DAP is stable and most critical features are ready.
Let's pin the version again and prevent breakages.

We don't update the latestVersion in this change -
currently dlv-dap uses this as the minimum required version.

Updates #1850
Updates #1661

Change-Id: Ib8af635f3ee431bffa1fc505f85c9a87604f8323
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/370414
Trust: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Polina Sokolova <[email protected]>
@hyangah hyangah modified the milestones: On Deck, v0.30.0 Dec 9, 2021
@golang golang locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
None yet
Milestone
v0.30.0
Development

No branches or pull requests
2 participants
@hyangah @gopherbot