Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/config.ts: add Gitpod to the known cloud-based IDEs #1616

Closed
wants to merge 1 commit into from

Conversation

svenefftinge
Copy link
Contributor

This change adds Gitpod to the recognized cloud-based IDEs to avoid showing the welcome screen in every workspace.

@google-cla
Copy link

google-cla bot commented Jul 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jul 9, 2021
@svenefftinge
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jul 9, 2021
@gopherbot
Copy link
Collaborator

This PR (HEAD: 0c41864) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/333489 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 1: Run-TryBot+1 Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/a982911b-c286-4776-ba11-ce86a6e9c870


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 1: TryBot-Result-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/a982911b-c286-4776-ba11-ce86a6e9c870


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Suzy Mueller:

Patch Set 1: Trust+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 070a46a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/333489 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 2: Run-TryBot+1 Code-Review+2 Trust+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/ec5f29c9-7d31-468e-bfcb-d4162064d67c


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from kokoro:

Patch Set 2: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/ec5f29c9-7d31-468e-bfcb-d4162064d67c


Please don’t reply on this GitHub thread. Visit golang.org/cl/333489.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jul 22, 2021
This change adds Gitpod to the recognized cloud-based IDEs to avoid showing the welcome screen in every workspace.

Change-Id: Ib195924d561b039ff2f1150f9f5855c427028669
GitHub-Last-Rev: 070a46a
GitHub-Pull-Request: #1616
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/333489
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Trust: Suzy Mueller <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
TryBot-Result: kokoro <[email protected]>
@hyangah hyangah added this to the v0.27.0 milestone Jul 22, 2021
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/333489 has been merged.

@gopherbot gopherbot closed this Jul 22, 2021
@svenefftinge svenefftinge deleted the patch-1 branch July 23, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants