-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/lsp: use x/xerrors to create new errors #108
Conversation
This PR (HEAD: 76f8316) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: de31d86) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 3706d2b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 53e600e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
After filing this PR I am wondering if that’s what was asked by the ticket? Should the logger also now log something additionally? I don't quite understand how the transition to go1.13 will behave, the documentation states most of the functionality will be absorbed into the standard lib. Will that make a transition back to |
Message from Rebecca Stambler: Patch Set 6: Thank you for opening this PR! Sorry about the delay in reviewing - there is a bug with the Github/Gerrit integration that prevents us from automatically adding reviewers. We'll take a look at it ASAP. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Ian Cottrell: Uploaded patch set 7: Run-TryBot+1. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 7: TryBots beginning. Status page: https://farmer.golang.org/try?commit=a13e7dd0 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 7: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 8: TryBots beginning. Status page: https://farmer.golang.org/try?commit=47800801 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 8: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: fc35060) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Jan Steinke: Patch Set 9: Run-TryBot+1. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: 2fe67fd) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Jan Steinke: Patch Set 9: No problem Rebecca :) I rebased my changes onto the latest state of master and fixed a few issues that popped up due to the changes. However, there is now one thing that I cannot understand. The
As this is an error case with an invalid point, I assume it is due to the move to xerrors and some matching onto the error message or something that is failing now. I don't see though where this is coming from. Do you have a hint where to look? Also: I was wondering if it might be smart to alias the package to Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Jan Steinke: Patch Set 10: One more thing: I only changed the errors in Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Jan Steinke: Patch Set 10:
I noticed that these tests also fail on master when I run 'em locally. Is there something special about these tests? Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Rebecca Stambler: Patch Set 10:
The test failures were due to https://go-review.googlesource.com/c/tools/+/185058 and fixed in https://go-review.googlesource.com/c/tools/+/185220. Sorry about that! Do you mind rebasing one more time? Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: 45f52f7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Jan Steinke: Patch Set 11:
Not at all :) Done! It's basically a race against you guys. There are new Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: 6e5686f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Rebecca Stambler: Patch Set 12: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 12: TryBots beginning. Status page: https://farmer.golang.org/try?commit=c0c67f7f Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 12: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Rebecca Stambler: Patch Set 12: -Run-TryBot These errors are probably related to https://go-review.googlesource.com/c/xerrors/+/184937, so that CL will need to be submitted before this one. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: db0cab5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Rebecca Stambler: Patch Set 13: (1 comment) Sorry about the delay here. This CL will have to be blocked by golang/go#32246. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: 6bfd3e5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 2cf133f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Rebecca Stambler: Patch Set 16: Run-TryBot+1 Code-Review+2 Looks like there is still a merge conflict here. Can you please resolve it, Jan? Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 16: TryBots beginning. Status page: https://farmer.golang.org/try?commit=0f797337 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 16: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This PR (HEAD: f4a55d9) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it. Tip: You can toggle comments from me using the |
Message from Jan Steinke: Patch Set 17: The repository is quite fast moving. I rebased again and fixed the conflicts.
Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Rebecca Stambler: Patch Set 17: Run-TryBot+1 Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 17: TryBots beginning. Status page: https://farmer.golang.org/try?commit=a1b442f0 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 17: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 17: TryBot-Result-1 1 of 10 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Rebecca Stambler: Patch Set 18: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 18: TryBots beginning. Status page: https://farmer.golang.org/try?commit=0b3ec735 Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 18: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
Message from Gobot Gobot: Patch Set 18: TryBot-Result-1 1 of 10 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/179880. |
This relates to golang/go#31374 and should switch all instances within `gopls` to use `x/errors` instead of `fmt` to create new errors. Change-Id: I18339b75d12418d852e0dcc2ba0ed6c2970783b3 GitHub-Last-Rev: f4a55d9 GitHub-Pull-Request: #108 Reviewed-on: https://go-review.googlesource.com/c/tools/+/179880 Run-TryBot: Rebecca Stambler <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
This PR is being closed because golang.org/cl/179880 has been merged. |
This relates to golang/go#31374 and should switch all instances within `gopls` to use `x/errors` instead of `fmt` to create new errors. Change-Id: I18339b75d12418d852e0dcc2ba0ed6c2970783b3 GitHub-Last-Rev: f4a55d9b79e7458ef1f1e06cb5eabbabd884f321 GitHub-Pull-Request: golang/tools#108 Reviewed-on: https://go-review.googlesource.com/c/tools/+/179880 Run-TryBot: Rebecca Stambler <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
This relates to golang/go#31374 and should switch all instances within
gopls
to usex/errors
instead offmt
to create new errors.