Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/lsp: use x/xerrors to create new errors #108

Closed
wants to merge 1 commit into from
Closed

internal/lsp: use x/xerrors to create new errors #108

wants to merge 1 commit into from

Conversation

jan-xyz
Copy link
Contributor

@jan-xyz jan-xyz commented May 31, 2019

This relates to golang/go#31374 and should switch all instances within gopls to use x/errors instead of fmt to create new errors.

@gopherbot
Copy link
Contributor

This PR (HEAD: 76f8316) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: de31d86) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 3706d2b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 53e600e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@jan-xyz jan-xyz changed the title use x/xerrors to create new errors internal/lsp: use x/xerrors to create new errors May 31, 2019
@jan-xyz
Copy link
Contributor Author

jan-xyz commented May 31, 2019

After filing this PR I am wondering if that’s what was asked by the ticket? Should the logger also now log something additionally?

I don't quite understand how the transition to go1.13 will behave, the documentation states most of the functionality will be absorbed into the standard lib. Will that make a transition back to fmt necessary in the future?

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 6:

Thank you for opening this PR! Sorry about the delay in reviewing - there is a bug with the Github/Gerrit integration that prevents us from automatically adding reviewers. We'll take a look at it ASAP.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Cottrell:

Uploaded patch set 7: Run-TryBot+1.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a13e7dd0


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 7:

Build is still in progress...
This change failed on linux-amd64 (Go 1.11.x):
See https://storage.googleapis.com/go-build-log/f0569288/linux-amd64_c70375e8.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 7: TryBot-Result-1

10 of 10 TryBots failed:
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/f0569288/linux-amd64_c70375e8.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/e62c3d35/linux-amd64_57c3f2ef.log
Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/39b533ed/linux-amd64_4f6fb140.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/e62c3d35/linux-386_8390a4f8.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/e62c3d35/freebsd-amd64-12_0_0917e4e0.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/e62c3d35/openbsd-amd64-64_b6c8e1b2.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/e62c3d35/windows-amd64-2016_4a0d0f00.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/e62c3d35/linux-amd64-race_715de312.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/e62c3d35/windows-386-2008_f72d563f.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/e62c3d35/android-amd64-emu_27b59b3e.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=47800801


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 8:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/e62c3d35/freebsd-amd64-12_0_26bd5c74.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 8: TryBot-Result-1

8 of 10 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/e62c3d35/freebsd-amd64-12_0_26bd5c74.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/e62c3d35/linux-386_85e7e664.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/e62c3d35/linux-amd64_056f902e.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/e62c3d35/openbsd-amd64-64_7888e541.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/e62c3d35/windows-amd64-2016_57165f3e.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/e62c3d35/windows-386-2008_c3a93061.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/e62c3d35/linux-amd64-race_b119dc11.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/e62c3d35/android-amd64-emu_649f5fad.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: fc35060) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jan Steinke:

Patch Set 9:

Run-TryBot+1.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2fe67fd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jan Steinke:

Patch Set 9:

No problem Rebecca :)

I rebased my changes onto the latest state of master and fixed a few issues that popped up due to the changes. However, there is now one thing that I cannot understand. The lsp_test fails

2019/07/06 14:23:20 Info: no signature help for file:///var/folders/6j/2n60g37s0f94qxz28gfx8fn40000gn/T/TestLSP_GOPATH003021802/lsp/src/golang.org/x/tools/internal/lsp/signature/signature.go:64:2 : no signature help within a function declaration
2019/07/06 14:23:31 Info: no signature help for file:///var/folders/6j/2n60g37s0f94qxz28gfx8fn40000gn/T/TestLSP_Modules846208577/primarymod/lsp/signature/signature.go:64:2 : no signature help within a function declaration
--- FAIL: TestBytesOffset (0.00s)
    lsp_test.go:830: want -1 for "aaa\nbbb\n"(Line:0,Character:4), but got 3
    lsp_test.go:830: want -1 for "aaa\nbbb\n"(Line:1,Character:4), but got 7
FAIL
FAIL	golang.org/x/tools/internal/lsp	20.126s

As this is an error case with an invalid point, I assume it is due to the move to xerrors and some matching onto the error message or something that is failing now. I don't see though where this is coming from. Do you have a hint where to look?

Also: I was wondering if it might be smart to alias the package to errors so that it is easier to switch to the stdlib implementation in go 1.13


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jan Steinke:

Patch Set 10:

One more thing: I only changed the errors in internal/lsp, do you think it's smart to do that as a first step, or should all errors be switched to xerrors?


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jan Steinke:

Patch Set 10:

Patch Set 9:

No problem Rebecca :)

I rebased my changes onto the latest state of master and fixed a few issues that popped up due to the changes. However, there is now one thing that I cannot understand. The lsp_test fails

2019/07/06 14:23:20 Info: no signature help for file:///var/folders/6j/2n60g37s0f94qxz28gfx8fn40000gn/T/TestLSP_GOPATH003021802/lsp/src/golang.org/x/tools/internal/lsp/signature/signature.go:64:2 : no signature help within a function declaration
2019/07/06 14:23:31 Info: no signature help for file:///var/folders/6j/2n60g37s0f94qxz28gfx8fn40000gn/T/TestLSP_Modules846208577/primarymod/lsp/signature/signature.go:64:2 : no signature help within a function declaration
--- FAIL: TestBytesOffset (0.00s)
    lsp_test.go:830: want -1 for "aaa\nbbb\n"(Line:0,Character:4), but got 3
    lsp_test.go:830: want -1 for "aaa\nbbb\n"(Line:1,Character:4), but got 7
FAIL
FAIL	golang.org/x/tools/internal/lsp	20.126s

As this is an error case with an invalid point, I assume it is due to the move to xerrors and some matching onto the error message or something that is failing now. I don't see though where this is coming from. Do you have a hint where to look?

Also: I was wondering if it might be smart to alias the package to errors so that it is easier to switch to the stdlib implementation in go 1.13

I noticed that these tests also fail on master when I run 'em locally. Is there something special about these tests?


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 10:

Patch Set 10:

Patch Set 9:

No problem Rebecca :)

I rebased my changes onto the latest state of master and fixed a few issues that popped up due to the changes. However, there is now one thing that I cannot understand. The lsp_test fails

2019/07/06 14:23:20 Info: no signature help for file:///var/folders/6j/2n60g37s0f94qxz28gfx8fn40000gn/T/TestLSP_GOPATH003021802/lsp/src/golang.org/x/tools/internal/lsp/signature/signature.go:64:2 : no signature help within a function declaration
2019/07/06 14:23:31 Info: no signature help for file:///var/folders/6j/2n60g37s0f94qxz28gfx8fn40000gn/T/TestLSP_Modules846208577/primarymod/lsp/signature/signature.go:64:2 : no signature help within a function declaration
--- FAIL: TestBytesOffset (0.00s)
    lsp_test.go:830: want -1 for "aaa\nbbb\n"(Line:0,Character:4), but got 3
    lsp_test.go:830: want -1 for "aaa\nbbb\n"(Line:1,Character:4), but got 7
FAIL
FAIL	golang.org/x/tools/internal/lsp	20.126s

As this is an error case with an invalid point, I assume it is due to the move to xerrors and some matching onto the error message or something that is failing now. I don't see though where this is coming from. Do you have a hint where to look?

Also: I was wondering if it might be smart to alias the package to errors so that it is easier to switch to the stdlib implementation in go 1.13

I noticed that these tests also fail on master when I run 'em locally. Is there something special about these tests?

The test failures were due to https://go-review.googlesource.com/c/tools/+/185058 and fixed in https://go-review.googlesource.com/c/tools/+/185220. Sorry about that! Do you mind rebasing one more time?


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 45f52f7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jan Steinke:

Patch Set 11:

The test failures were due to https://go-review.googlesource.com/c/tools/+/185058 and fixed in https://go-review.googlesource.com/c/tools/+/185220. Sorry about that! Do you mind rebasing one more time?

Not at all :) Done!

It's basically a race against you guys. There are new fmt.Errorf that come in with each new merge. So excuse me for not converting all.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6e5686f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 12: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 12:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=c0c67f7f


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 12:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/a19c0ced/freebsd-amd64-12_0_39c962de.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 12: TryBot-Result-1

8 of 10 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/a19c0ced/freebsd-amd64-12_0_39c962de.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/a19c0ced/linux-amd64_7e4b47fc.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/a19c0ced/linux-386_76e676ff.log
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/a19c0ced/openbsd-amd64-64_230c132c.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/a19c0ced/windows-amd64-2016_1ce079d6.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/a19c0ced/windows-386-2008_28ca69b0.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/a19c0ced/linux-amd64-race_0a8e7c55.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/a19c0ced/android-amd64-emu_a930a930.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 12: -Run-TryBot

These errors are probably related to https://go-review.googlesource.com/c/xerrors/+/184937, so that CL will need to be submitted before this one.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: db0cab5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 13:

(1 comment)

Sorry about the delay here. This CL will have to be blocked by golang/go#32246.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6bfd3e5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 2cf133f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 16: Run-TryBot+1 Code-Review+2

Looks like there is still a merge conflict here. Can you please resolve it, Jan? Thanks!


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 16:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0f797337


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 16:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/d1338ec3/freebsd-amd64-12_0_adff9fa6.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 16: TryBot-Result-1

8 of 10 TryBots failed:
Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/d1338ec3/openbsd-amd64-64_48c703e1.log
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/d1338ec3/freebsd-amd64-12_0_adff9fa6.log
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/d1338ec3/linux-amd64_639d19a5.log
Failed on linux-386: https://storage.googleapis.com/go-build-log/d1338ec3/linux-386_5256eaa8.log
Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/d1338ec3/linux-amd64-race_229b2ac1.log
Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/d1338ec3/android-amd64-emu_1219da01.log
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/d1338ec3/windows-amd64-2016_06ba834e.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/d1338ec3/windows-386-2008_34279934.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: f4a55d9) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/179880 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Jan Steinke:

Patch Set 17:

The repository is quite fast moving. I rebased again and fixed the conflicts.

Patch Set 16: Run-TryBot+1 Code-Review+2

Looks like there is still a merge conflict here. Can you please resolve it, Jan? Thanks!


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 17: Run-TryBot+1

Thanks!


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 17:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a1b442f0


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 17:

Build is still in progress...
This change failed on linux-amd64 (Go 1.11.x):
See https://storage.googleapis.com/go-build-log/7a853b65/linux-amd64_dcd0ddee.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 17: TryBot-Result-1

1 of 10 TryBots failed:
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/7a853b65/linux-amd64_dcd0ddee.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rebecca Stambler:

Patch Set 18: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 18:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0b3ec735


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 18:

Build is still in progress...
This change failed on linux-amd64 (Go 1.11.x):
See https://storage.googleapis.com/go-build-log/7a853b65/linux-amd64_f973c0d1.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 18: TryBot-Result-1

1 of 10 TryBots failed:
Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/7a853b65/linux-amd64_f973c0d1.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.


Please don’t reply on this GitHub thread. Visit golang.org/cl/179880.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 6, 2019
This relates to golang/go#31374 and should switch all instances within `gopls` to use `x/errors` instead of `fmt` to create new errors.

Change-Id: I18339b75d12418d852e0dcc2ba0ed6c2970783b3
GitHub-Last-Rev: f4a55d9
GitHub-Pull-Request: #108
Reviewed-on: https://go-review.googlesource.com/c/tools/+/179880
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/179880 has been merged.

@gopherbot gopherbot closed this Aug 6, 2019
@jan-xyz jan-xyz deleted the xerror branch August 8, 2019 18:48
apstndb pushed a commit to apstndb/gotoolsdiff that referenced this pull request Jan 11, 2025
This relates to golang/go#31374 and should switch all instances within `gopls` to use `x/errors` instead of `fmt` to create new errors.

Change-Id: I18339b75d12418d852e0dcc2ba0ed6c2970783b3
GitHub-Last-Rev: f4a55d9b79e7458ef1f1e06cb5eabbabd884f321
GitHub-Pull-Request: golang/tools#108
Reviewed-on: https://go-review.googlesource.com/c/tools/+/179880
Run-TryBot: Rebecca Stambler <[email protected]>
Reviewed-by: Rebecca Stambler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants