-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html: fix SOLIDUS '/' handling in attribute parsing #195
html: fix SOLIDUS '/' handling in attribute parsing #195
Conversation
Calling the Tokenizer with HTML element containing SOLIDUS (/) in the attribute name results in incorrect tokenization. This is due to violation of the following rule transitions in the WHATWG spec: - https://html.spec.whatwg.org/multipage/parsing.html#attribute-name-state (we are not reconsuming the character if '/' is encountered) - https://html.spec.whatwg.org/multipage/parsing.html#after-attribute-name-state (we are not switching to self closing state) Fixes golang/go#63402 Signed-off-by: Maciej Mionskowski <[email protected]>
0855e0f
to
3546db8
Compare
This PR (HEAD: 3546db8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/533518. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Maciej Mionskowski: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Roland Shoemaker: Patch Set 3: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-15T23:31:36Z","revision":"4027ac35682587ab7c1877eed84e8b90553883ed"} Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Roland Shoemaker: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Message from David Chase: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/533518. |
Calling the Tokenizer with HTML elements containing SOLIDUS (/) character in the attribute name results in incorrect tokenization. This is due to violation of the following rule transitions in the WHATWG spec: - https://html.spec.whatwg.org/multipage/parsing.html#attribute-name-state, where we are not reconsuming the character if '/' is encountered - https://html.spec.whatwg.org/multipage/parsing.html#after-attribute-name-state, where we are not switching to self closing state Fixes golang/go#63402 Change-Id: I90d998dd8decde877bd63aa664f3657aa6161024 GitHub-Last-Rev: 3546db8 GitHub-Pull-Request: #195 Reviewed-on: https://go-review.googlesource.com/c/net/+/533518 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Michael Pratt <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: David Chase <[email protected]>
This PR is being closed because golang.org/cl/533518 has been merged. |
Calling the Tokenizer with HTML elements containing SOLIDUS (/) character
in the attribute name results in incorrect tokenization.
This is due to violation of the following rule transitions in the WHATWG spec:
where we are not reconsuming the character if '/' is encountered
where we are not switching to self closing state
Fixes golang/go#63402