the testing package may cause a crash

[daocoder2]

Go version

go version go1.22.7 linux/amd64

Output of go env in your module/workspace:

GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn,direct'
GOROOT='/usr/local/go'
GOSUMDB='off'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.7'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD='/assert_rdg/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3465843287=/tmp/go-build -gno-record-gcc-switches'

What did you do?

package main


import (
    "testing"
    "fmt"
    "github.com/stretchr/testify/assert"
)

func main() {
    t := &testing.T{}
    res := assert.EqualValues(t, "1", "0", nil)
    fmt.Println(res)
}

What did you see happen?

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4c0460]

goroutine 1 [running]:
testing.(*common).decorate(0x7ff35d8668c8?, {0xc000200540, 0x1b7}, 0x1c0?)
/usr/local/go/src/testing/testing.go:777 +0xa0
testing.(*common).logDepth(0xc0001384e0, {0xc000200540, 0x1b7}, 0x3)
/usr/local/go/src/testing/testing.go:1044 +0x1dd
testing.(*common).log(...)
/usr/local/go/src/testing/testing.go:1013
testing.(*common).Errorf(0xc0001384e0, {0x58d565?, 0x40b845?}, {0xc000014370?, 0x55af60?, 0x101?})
/usr/local/go/src/testing/testing.go:1077 +0x54
github.com/stretchr/testify/assert.Fail({0x5e14e0, 0xc0001384e0}, {0xc0000242a0, 0x59}, {0xc00018ff20, 0x1, 0x1})
/root/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:363 +0x370
github.com/stretchr/testify/assert.EqualValues({0x5e14e0, 0xc0001384e0}, {0x55a960, 0x5e0868}, {0x55a960, 0x5e0878}, {0xc00018ff20, 0x1, 0x1})
/root/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:587 +0x1fd
main.main()
/assert_rdg/main.go:12 +0x5f

What did you expect to see?

I'm not sure if it's just my usage problem.
The test package did not use the go test command, so the variable fullPath was not initialized.
Finally, it crashes when the assertion is wrong.

The possible reasons are as follows:

	if file != "" {
		if *fullPath {
			// If relative path, truncate file name at last file name separator.
		} else if index := strings.LastIndexAny(file, `/\`); index >= 0 {
			file = file[index+1:]
		}
	} else {
		file = "???"
	}

[gabyhelp]

Related Issues and Documentation

• runtime: go1.22.0 test with -race will SIGSEGV or SIGBUS or Bad Pointer #65783 (closed)
• cmd/go: panic when building a `main` package in GOPATH mode when a go.work file exists #58767 (closed)
• x/tools/go/packages: nil pointer dereference #69524 (closed)
• x/tools/go/analysis/passes/slog: nil panic in `isAttr` via `analysisutil.IsNamed` #61228 (closed)
• runtime: SIGSEGV in mapassign_fast64 during cmd/vet #35689 (closed)
• x/tools/go/packages: Crash on Go 1.10.x with cgo disabled. #29505 (closed)
• x/tools/go/packages, go/ast: NewPackage causes SIGSEGV #37202 (closed)
• cmd/go: panic in 'go work use' #50958 (closed)
• runtime/debug: TestStack fail #65506 (closed)
• cmd/link: run tests failed with lots of cases in buildmode=shared #26400 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[seankhliao]

testing.T is not intended to be used outside of tests.