Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/example/ragserver/ragserver: requires go1.23.0, so go1.22 builders are redundant with go1.23 builders #69332

Closed
dmitshur opened this issue Sep 6, 2024 · 2 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Sep 6, 2024

One of the nested modules in x/example can't be tested on the Go 1.22 release branch, not without upgrading to a Go 1.23 toolchain, as reported by its LUCI builders here (added recently in CL 608495):

https://ci.chromium.org/p/golang/g/x-example-go1.22/console

It's probably fine for some modules in x/example to require Go 1.23 or newer. Perhaps we don't need to test that it works with Go 1.22?

Note that there are already tests for cmd/go toolchain switching behavior elsewhere; so we don't benefit from running all the macOS/Linux/Windows builders with the default GOTOOLCHAIN=local+auto if they'll just repeat the work of equivalent go1.23 builders. We also don't want the dashboard to be red (issue #11811), so filing this to track next steps.

CC @eliben, @mknyszek.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 6, 2024
@dmitshur dmitshur added this to the Unreleased milestone Sep 6, 2024
@eliben
Copy link
Member

eliben commented Sep 13, 2024

It's probably fine for some modules in x/example to require Go 1.23 or newer. Perhaps we don't need to test that it works with Go 1.22?

Examples - by their nature - demonstrate new features, so it's really valuable to be able to restrict them to only the newest version of Go.

@dmitshur dmitshur self-assigned this Sep 16, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 16, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Sep 16, 2024
@dmitshur
Copy link
Contributor Author

dmitshur commented Sep 17, 2024

Fixed in crrev.com/c/5869577.

Specifically, release branch builders (e.g., x_example-go1.22-linux-amd64) will now skip testing modules that have a go directive that's too high for that particular builder, at least when GOTOOLCHAIN=local is in the environment. Other modules are still tested. Go tip builders don't do this kind of skipping so that accidental go 1.220 directives are caught.

image

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants