You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the nested modules in x/example can't be tested on the Go 1.22 release branch, not without upgrading to a Go 1.23 toolchain, as reported by its LUCI builders here (added recently in CL 608495):
It's probably fine for some modules in x/example to require Go 1.23 or newer. Perhaps we don't need to test that it works with Go 1.22?
Note that there are already tests for cmd/go toolchain switching behavior elsewhere; so we don't benefit from running all the macOS/Linux/Windows builders with the default GOTOOLCHAIN=local+auto if they'll just repeat the work of equivalent go1.23 builders. We also don't want the dashboard to be red (issue #11811), so filing this to track next steps.
The text was updated successfully, but these errors were encountered:
dmitshur
added
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Sep 6, 2024
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Sep 16, 2024
Specifically, release branch builders (e.g., x_example-go1.22-linux-amd64) will now skip testing modules that have a go directive that's too high for that particular builder, at least when GOTOOLCHAIN=local is in the environment. Other modules are still tested. Go tip builders don't do this kind of skipping so that accidental go 1.220 directives are caught.
One of the nested modules in x/example can't be tested on the Go 1.22 release branch, not without upgrading to a Go 1.23 toolchain, as reported by its LUCI builders here (added recently in CL 608495):
https://ci.chromium.org/p/golang/g/x-example-go1.22/console
It's probably fine for some modules in x/example to require Go 1.23 or newer. Perhaps we don't need to test that it works with Go 1.22?
Note that there are already tests for cmd/go toolchain switching behavior elsewhere; so we don't benefit from running all the macOS/Linux/Windows builders with the default GOTOOLCHAIN=local+auto if they'll just repeat the work of equivalent go1.23 builders. We also don't want the dashboard to be red (issue #11811), so filing this to track next steps.
CC @eliben, @mknyszek.
The text was updated successfully, but these errors were encountered: