x/tools/gopls: TestAssembly failed with CALL/RET not found on riscv64

[mengzhuo]

Go version

go version go1.22.3 linux/riscv64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='riscv64'
GOBIN=''
GOCACHE='/root/.cache/go-build'
GOENV='/root/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='riscv64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/root/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/root/go'
GOPRIVATE=''
GOPROXY='https://goproxy.cn'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_riscv64'
GOVCS=''
GOVERSION='go1.22.3'
GCCGO='gccgo'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/root/tools/gopls/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1899499080=/tmp/go-build -gno-record-gcc-switches'

What did you do?

Found this failure on LUCI and I try run this on my riscv64 box is real.
https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-go1.22-linux-riscv64/b8745302670138690817/test-results?sortby=&groupby=

What did you see happen?

I found this in

input did not match wanted pattern "CALL\truntime.morestack_noctxt"; got:
...
JAL     X5, runtime.morestack_noctxt(SB)

Maybe something changed in obj/asm?

What did you expect to see?

Test pass

[gabyhelp]

Similar Issues

• cmd/compile: failed to make Go on riscv64 CPU with numa #61295
• cmd/go: internal/test.test build faild on linux/loong64 #67538
• syscall: build test failure on linux-ppc64 #42178
• runtime/debug: TestStack fail #65506
• os: TestLstat failure on Linux Aarch64 #57210

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[findleyr]

Thanks for the report. Looks like we need to skip this test or loosen it's assumptions w.r.t. generated assembly.

[gopherbot]

Change https://go.dev/cl/592476 mentions this issue: gopls/internal/test/integration/misc: skip ASM assertions on risc64