-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database/sql: sql.RawBytes is not compatible with contexts [1.20 backport] #60308
Comments
Release planning suggests waiting for the CL to ship in 1.21 RC1 before backporting. |
Will also need https://go-review.googlesource.com/c/go/+/498398 it turns out. |
The report in issue #60932 looks relevant to the review of this cherry-pick candidate. |
There has been enough uncertainty around the database/sql change that, while I think it is appropriate for Go 1.21, I am inclined to not backport it to Go 1.20. |
@cherrymui What information do you think this is waiting for? I think given the new information, we can make a decision (not to backport this), like in #60307. |
I think we decided to give it some time to soak, wait for 1.21 release then decide later (for 1.20 backport only, definitely not enough time for 1.19 backport.) |
We've considered the information available by now and have decided not to proceed with this backport. The fix is available in Go 1.21.0 onwards, but the risk of backporting doesn't outweigh the benefits. |
@rsc requested issue #60304 to be considered for backport to the next 1.20 minor release.
The text was updated successfully, but these errors were encountered: