Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/imports: TestSimpleCases failures #57367

Closed
gopherbot opened this issue Dec 17, 2022 · 4 comments
Closed

x/tools/internal/imports: TestSimpleCases failures #57367

gopherbot opened this issue Dec 17, 2022 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/imports" && test == "TestSimpleCases"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestSimpleCases (22.73s)
    --- FAIL: TestSimpleCases/remove_unused_2_of_2 (0.50s)
        --- FAIL: TestSimpleCases/remove_unused_2_of_2/Modules (0.42s)
            fix_test.go:1228: err: fork/exec C:\workdir\go\bin\go.exe: The paging file is too small for this operation to complete.: stderr: 
    --- FAIL: TestSimpleCases/remove_unused_1_of_1 (0.11s)
        --- FAIL: TestSimpleCases/remove_unused_1_of_1/Modules (0.08s)
            fix_test.go:1228: err: fork/exec C:\workdir\go\bin\go.exe: Insufficient system resources exist to complete the requested service.: stderr: 

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 17, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/imports" && test == "TestSimpleCases"
2022-12-07 15:31 windows-arm64-11 tools@09fb680d go@dc04f3ba x/tools/internal/imports.TestSimpleCases (log)
--- FAIL: TestSimpleCases (22.73s)
    --- FAIL: TestSimpleCases/remove_unused_2_of_2 (0.50s)
        --- FAIL: TestSimpleCases/remove_unused_2_of_2/Modules (0.42s)
            fix_test.go:1228: err: fork/exec C:\workdir\go\bin\go.exe: The paging file is too small for this operation to complete.: stderr: 
    --- FAIL: TestSimpleCases/remove_unused_1_of_1 (0.11s)
        --- FAIL: TestSimpleCases/remove_unused_1_of_1/Modules (0.08s)
            fix_test.go:1228: err: fork/exec C:\workdir\go\bin\go.exe: Insufficient system resources exist to complete the requested service.: stderr: 

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 1, 2023

Duplicate of #51019

@bcmills bcmills marked this as a duplicate of #51019 Feb 1, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/internal/imports" && test == "TestSimpleCases"
2023-04-06 17:53 windows-amd64-race tools@c5f768a4 go@4526fa79 x/tools/internal/imports.TestSimpleCases (log)
runtime: bad pointer in frame os.(*File).readdir at 0xc000187ba8: 0x140
fatal error: invalid pointer found on stack

runtime stack:
runtime.throw({0x140430d04?, 0x140633fe0?})
	C:/workdir/go/src/runtime/panic.go:1076 +0x65 fp=0x2805f5b0 sp=0x2805f580 pc=0x140039405
runtime.adjustpointers(0x2805f828?, 0x2805f670, 0x14005efdf?, {0x2805f828?, 0x0?})
	C:/workdir/go/src/runtime/stack.go:632 +0x1ad fp=0x2805f610 sp=0x2805f5b0 pc=0x14005116d
runtime.adjustframe(0x2805f828, 0x2805f708)
	C:/workdir/go/src/runtime/stack.go:673 +0xbb fp=0x2805f6a0 sp=0x2805f610 pc=0x14005127b
...
	C:/workdir/go/src/runtime/proc.go:392 +0xce fp=0xc000057c78 sp=0xc000057c58 pc=0x14003be4e
runtime.chanrecv(0xc000117180, 0xc000057d5e, 0x1)
	C:/workdir/go/src/runtime/chan.go:583 +0x385 fp=0xc000057cf0 sp=0xc000057c78 pc=0x140006905
runtime.chanrecv1(0x140654180?, 0x1403af240?)
	C:/workdir/go/src/runtime/chan.go:442 +0x12 fp=0xc000057d18 sp=0xc000057cf0 pc=0x140006552
testing.(*T).Run(0xc000085520, {0x1404229ff, 0x11}, 0xc00008ae20)
	C:/workdir/go/src/testing/testing.go:1649 +0x865 fp=0xc000057e38 sp=0xc000057d18 pc=0x14015b0a5
golang.org/x/tools/internal/imports.TestSimpleCases(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/internal/imports/fix_test.go:1191 +0x85 fp=0xc000057e98 sp=0xc000057e38 pc=0x1403064a5
testing.tRunner(0xc000085520, 0x140441a20)

watchflakes

@gopherbot gopherbot reopened this Apr 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Apr 10, 2023

The above was a regression introduced in CL 482536 and rolled back in CL 482817.

I believe that watchflakes didn't file an issue for it otherwise because the windows-amd64-race builder was failing at every commit, and watchflakes currently does not file issues for builders than are completely broken (that's #58819).

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2023
@golang golang locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Archived in project
Development

No branches or pull requests

2 participants