Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestInvalidFilesBeforeOverlayContains failures #57366

Open
gopherbot opened this issue Dec 17, 2022 · 4 comments
Open

x/tools/go/packages: TestInvalidFilesBeforeOverlayContains failures #57366

gopherbot opened this issue Dec 17, 2022 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestInvalidFilesBeforeOverlayContains"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestInvalidFilesBeforeOverlayContains (0.00s)
    --- FAIL: TestInvalidFilesBeforeOverlayContains/Modules (20.97s)
        --- FAIL: TestInvalidFilesBeforeOverlayContains/Modules/second_file (0.54s)
            overlay_test.go:831: expected package ID "golang.org/fake/d", got "command-line-arguments"

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 17, 2022
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Dec 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestInvalidFilesBeforeOverlayContains"
2022-12-07 15:31 windows-arm64-11 tools@09fb680d go@dc04f3ba x/tools/go/packages.TestInvalidFilesBeforeOverlayContains (log) 
--- FAIL: TestInvalidFilesBeforeOverlayContains (0.00s)
    --- FAIL: TestInvalidFilesBeforeOverlayContains/Modules (20.97s)
        --- FAIL: TestInvalidFilesBeforeOverlayContains/Modules/second_file (0.54s)
            overlay_test.go:831: expected package ID "golang.org/fake/d", got "command-line-arguments"

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 1, 2023

Duplicate of #51019

@bcmills bcmills marked this as a duplicate of #51019 Feb 1, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2023
@gopherbot gopherbot reopened this Jan 5, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestInvalidFilesBeforeOverlayContains"
2024-01-03 12:29 darwin-amd64-10_15 tools@a863a4fc go@d2cb1401 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains (log) 
--- FAIL: TestInvalidFilesBeforeOverlayContains (0.00s)
    --- FAIL: TestInvalidFilesBeforeOverlayContains/Modules (55.65s)
        --- FAIL: TestInvalidFilesBeforeOverlayContains/Modules/xtest (9.03s)
            overlay_test.go:824: expected package ID "golang.org/fake/d_test [golang.org/fake/d.test]", got "command-line-arguments_test [command-line-arguments.test]"

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestInvalidFilesBeforeOverlayContains"
2024-01-03 10:09 x_tools-go1.22-netbsd-arm64 tools@5e6f314f release-branch.go1.22@fa72f3e0 x/tools/go/packages.TestInvalidFilesBeforeOverlayContains [ABORT] (log) 
=== RUN   TestInvalidFilesBeforeOverlayContains
=== PAUSE TestInvalidFilesBeforeOverlayContains
=== CONT  TestInvalidFilesBeforeOverlayContains

— watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot