x/pkgsite: '' is rendered as smart doublequotes in <pre> block

[kortschak]

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/google/[email protected]/ext#hdr-Join

What is your user agent?

Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:98.0) Gecko/20100101 Firefox/98.0

Screenshot

What did you do?

What did you expect to see?

No smart quotes in <pre> blocks.

What did you see instead?

Smart quotes in <pre> blocks.

[gopherbot]

Change https://go.dev/cl/394034 mentions this issue: internal/godoc/dochtml/internal/render: don't smart quote in <pre> blocks

[kortschak]

On further thought, given that authors can already encode “ and ” through unicode in the source if they really want it, and the quote conversion makes it impossible to express things like empty strings from some other languages (and empty raw strings in Go) and quoted single quotes in SQL, I think it would be better to just remove this feature.

[mvdan]

I would also remove "quote conversion" entirely, not just in <pre> blocks, but perhaps I'm missing what was the point of adding that in the first place.

[seebs]

"Smart" quote conversion isn't.

[jamalc]

Let's limit this issue to removing the conversion in <pre> blocks to fix the bug.

[kortschak]

@jamalc I will send another PR completely removing this for discussion. Given the changes that @rsc has made in the content in https://go.dev/cl/384262 changing '' to “ and ” it would make sense not to double process, particularly given the issues I raise above.