Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/poll: deadlock in Read on arm64 when an FD is closed [1.16 backport] #50610

Closed
gopherbot opened this issue Jan 14, 2022 · 4 comments
Closed

internal/poll: deadlock in Read on arm64 when an FD is closed [1.16 backport] #50610

gopherbot opened this issue Jan 14, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.16.16

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #45211 to be considered for backport to the next 1.16 minor release.

@gopherbot, please backport to 1.17 and 1.16: this is a race condition that can result in deadlocks on ARM64 in any process that relies on Close unblocking a read. It is tricky to diagnose (and hard to reproduce reliably), and there is no apparent workaround for users on ARM64 machines.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 14, 2022
@gopherbot gopherbot mentioned this issue Jan 14, 2022
Closed
@gopherbot gopherbot added this to the Go1.16.14 milestone Jan 14, 2022
@cherrymui cherrymui modified the milestones: Go1.16.14, Go1.16.15 Feb 9, 2022
@toothrot
Copy link
Contributor

toothrot commented Feb 9, 2022

Approved. This is a serious issue with no workaround.

@toothrot toothrot added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 9, 2022
@dmitshur dmitshur mentioned this issue Feb 18, 2022
Closed
@cagedmantis cagedmantis modified the milestones: Go1.16.15, Go1.16.16 Mar 3, 2022
@heschi
Copy link
Contributor

heschi commented Mar 14, 2022

@bcmills @rsc @ianlancetaylor

This backport is at risk of missing the next minor release.

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/392576 mentions this issue: [release-branch.go1.16] runtime: fix net poll races

@heschi
Copy link
Contributor

heschi commented Mar 16, 2022

1.16 is no longer supported; closing this backport request. (Sorry for pinging it Monday.)

@heschi heschi closed this as completed Mar 16, 2022
@golang golang locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.16.16
Development

No branches or pull requests
5 participants
@toothrot @cagedmantis @gopherbot @cherrymui @heschi