Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embed: remove type spelling restrictions #43602

Closed
rsc opened this issue Jan 8, 2021 · 4 comments
Closed

embed: remove type spelling restrictions #43602

rsc opened this issue Jan 8, 2021 · 4 comments
Labels
FrozenDueToAge Proposal Proposal-Accepted
Milestone
Backlog

Comments

@rsc
Copy link
Contributor

rsc commented Jan 8, 2021

In #43217 (comment) I suggested two changes:

  • Drop the import restriction for embed.
  • Drop the type spelling restrictions for embed.

The reaction is for the most part overwhelmingly positive. But dropping the import restriction has generated some important discussion, while dropping the type spelling restriction seems completely uncontroversial.

I've forked this issue off of #43217 to track only dropping the type spelling restriction. Then #43217 can be only about dropping the import restriction.
@rsc rsc added this to the Proposal milestone Jan 8, 2021
@rsc
Copy link
Contributor Author

rsc commented Jan 8, 2021

(The Likely Accept is inherited from #43217, which this was split off from.)

@rsc rsc mentioned this issue Jan 8, 2021
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/282715 mentions this issue: cmd/compile: allow embed into any string or byte slice type

@rsc
Copy link
Contributor Author

rsc commented Jan 13, 2021

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: embed: remove type spelling restrictions embed: remove type spelling restrictions Jan 13, 2021
@rsc rsc modified the milestones: Proposal, Backlog Jan 13, 2021
@rsc rsc mentioned this issue Jan 13, 2021
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/288072 mentions this issue: embed: update docs for proposal tweaks

gopherbot pushed a commit that referenced this issue Jan 29, 2021
@ianlancetaylor
embed: update docs for proposal tweaks
4436114 
//go:embed variables can be type aliases.

//go:embed variables can't be local to a function.

For #43216
For #43602
Fixes #43978

Change-Id: Ib1d104dfa32b97c91d8bfc5ed5d461ca14da188f
Reviewed-on: https://go-review.googlesource.com/c/go/+/288072
Trust: Ian Lance Taylor <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
@korzhao korzhao mentioned this issue Aug 17, 2021
Closed
@golang golang locked and limited conversation to collaborators Jan 29, 2022
@rsc rsc added this to Proposals Aug 10, 2022
@rsc rsc moved this to Accepted in Proposals Aug 10, 2022
@rsc rsc removed this from Proposals Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Proposal Proposal-Accepted
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@rsc @gopherbot and others